Support per-folder enable/disable for the singleton server in multi-root workspaces - #62
Draft
Eduardo Villalpando Mello (edvilme) with Copilot wants to merge 3 commits into
Draft
Eduardo Villalpando Mello (edvilme) with Copilot wants to merge 3 commits into
Eduardo Villalpando Mello (edvilme) with Copilot wants to merge 3 commits into
Conversation
Copilot started work on behalf of
Eduardo Villalpando Mello (edvilme)
June 17, 2026 20:14
View session
Copilot
AI
changed the title
[WIP] Add support for singleton server instance in multi-root workspaces
Support per-folder enable/disable for the singleton server in multi-root workspaces
Jun 17, 2026
Copilot started work on behalf of
Eduardo Villalpando Mello (edvilme)
September 14, 2026 16:58
View session
…eton-server-instance # Conflicts: # typescript/src/settings.ts Co-authored-by: edvilme <[email protected]>
Eduardo Villalpando Mello (edvilme)
requested a balanced review from Copilot
September 14, 2026 17:04
Copilot started reviewing on behalf of
Eduardo Villalpando Mello (edvilme)
September 14, 2026 17:05
View session
There was a problem hiding this comment.
🟡 Changes recommended
Omitted folders still receive enabled server defaults, and a duplicate import prevents test compilation.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds per-folder tool enablement for singleton LSP servers in multi-root workspaces.
Changes:
- Adds enablement helpers and workspace filtering.
- Exports and documents the new APIs.
- Adds multi-root tests.
File summaries
| File | Description |
|---|---|
typescript/src/settings.ts |
Implements enablement filtering. |
typescript/src/index.ts |
Exports new helpers. |
typescript/tests/settingsWorkspace.test.ts |
Adds enablement tests. |
README.md |
Documents multi-root behavior. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+346
to
+347
| workspaces.filter((w) => isToolEnabledForWorkspace(namespace, w)).map((w) => | ||
| getWorkspaceSettings(namespace, w, toolConfig, resolveInterpreter), |
Comment on lines
+11
to
13
| getExtensionSettings, | ||
| getExtraPaths, | ||
| getExtensionSettings, |
Comment on lines
+75
to
+77
| - `getExtensionSettings(namespace, toolConfig, resolveInterpreter)` automatically | ||
| omits folders where the tool is disabled, so the shared server never lints | ||
| opted-out folders. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool extensions consuming this library risk redundant LSP processes and duplicated diagnostics in multi-root workspaces. The TypeScript client already runs a singleton server (one client rooted at
getProjectRoot(), per-folder settings forwarded viagetExtensionSettings()), so the gap was the lack of a per-folder opt-out (e.g.pylint.enabled: falsefor a single folder).Changes
settings.tsisToolEnabledForWorkspace(namespace, workspace?, settingKey?)— reads the per-folder<namespace>.enabledboolean; defaults to enabled,settingKeyoverridable (e.g.'enable').getEnabledWorkspaceFolders(namespace, settingKey?)— folders for which the tool is enabled.getExtensionSettings()now resolves settings only for enabled folders, so the shared server never lints opted-out folders. Backward compatible: unset → enabled.index.ts— export the two new helpers.getExtensionSettings.Example
Note:
getExtensionSettings()filtering changes which folders reach the server when a tool exposes anenabledsetting and a user disables a folder — worth a careful look during review, though defaults preserve existing behavior.