Update inactive regions to support column granularity - #14667
Merged
Colen Garoutte-Carson (Colengms) merged 2 commits intoAug 13, 2026
Conversation
Colen Garoutte-Carson (Colengms)
requested a review
from a team
as a code owner
August 12, 2026 00:41
Contributor
|
Thanks for the update, Colen Garoutte-Carson (@Colengms) . |
Sean McManus (sean-mcmanus)
approved these changes
Aug 13, 2026
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
August 13, 2026 14:02
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates inactive-region decorations to support column-level precision while preserving line-only folding ranges.
Changes:
- Adds column fields to inactive regions.
- Introduces a line-only range type for code folding.
- Applies precise ranges to inactive-region decorations.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Colen Garoutte-Carson (Colengms)
deleted the
dev/coleng/inactive_regions_columns
branch
August 13, 2026 20:42
Sean McManus (sean-mcmanus)
added a commit
that referenced
this pull request
Aug 21, 2026
* Validate Yarn lockfile selectors (#14663) * Fix IntelliSense translation strings. (#14668) * Fix IntelliSense translation strings. * Handle localization path casing generically (#14669) * Update changelog and version for 1.33.8 (#14671) * Fix configuration path regex escaping (#14674) * Update inactive regions to support column granularity (#14667) Co-authored-by: @8prashant (Prashant Kumar Rai) * Bump the github-actions group with 2 updates (#14678) Bumps the github-actions group with 2 updates: [github/codeql-action/init](https://github.com/github/codeql-action) and [github/codeql-action/analyze](https://github.com/github/codeql-action). Updates `github/codeql-action/init` from 4.37.4 to 4.37.6 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f205ea1...5595cca) Updates `github/codeql-action/analyze` from 4.37.4 to 4.37.6 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f205ea1...5595cca) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.37.6 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: github/codeql-action/analyze dependency-version: 4.37.6 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Upgrade nanoid to 3.3.18 (#14690) * Fix SimpleCppProject test setup (#14687) * Update IntelliSense localization strings (#14676) * Ignore process wait test helper (#14694) * Retry OneLocBuild dependency installation (#14697) * Add localized warning for disabled browse database (#14683) * Add localized browse database warning * Clarify browse warning translator hint --------- Co-authored-by: Colen Garoutte-Carson <[email protected]> * Harden Linux gdb installation (#14695) * Fix configuration path diagnostic ranges (#14679) * Bump the github-actions group with 2 updates (#14698) Bumps the github-actions group with 2 updates: [github/codeql-action/init](https://github.com/github/codeql-action) and [github/codeql-action/analyze](https://github.com/github/codeql-action). Updates `github/codeql-action/init` from 4.37.6 to 4.37.7 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@5595cca...ff2f1c6) Updates `github/codeql-action/analyze` from 4.37.6 to 4.37.7 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@5595cca...ff2f1c6) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.37.7 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: github/codeql-action/analyze dependency-version: 4.37.7 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update changelog and version for 1.34.0 (#14700) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Colen Garoutte-Carson <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added column fields.
Broke out a separate line-only object for code folding, which doesn't currently support column offsets.