Implement session state tracking for "Run and Debug" button when Inte… - #14719
Merged
Conversation
…lliSense is disabled and add corresponding tests
Prashant Kumar Rai (8prashant)
force-pushed
the
main
branch
from
August 31, 2026 06:49
c556c18 to
47035c5
Compare
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
August 31, 2026 11:03
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures Run/Debug editor actions remain available when IntelliSense is disabled.
Changes:
- Tracks active editor changes in the debugger extension.
- Updates build/debug session context keys.
- Adds source, header, non-C/C++, and undefined-editor tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Extension/src/Debugger/extension.ts |
Adds independent session-state tracking. |
Extension/test/scenarios/SingleRootProject/tests/buildAndDebug.test.ts |
Tests source-file state updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sean McManus (sean-mcmanus)
left a comment
Contributor
There was a problem hiding this comment.
Found one session-state lifecycle gap that should be addressed before merging.
… open status and adding tests
Copilot started reviewing on behalf of
Prashant Kumar Rai (8prashant)
September 1, 2026 17:18
View session
Copilot started reviewing on behalf of
Prashant Kumar Rai (8prashant)
September 1, 2026 17:40
View session
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Copilot started reviewing on behalf of
Prashant Kumar Rai (8prashant)
September 2, 2026 16:57
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Active-document language-mode changes can leave the Run/Debug context stale.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Copilot started reviewing on behalf of
Prashant Kumar Rai (8prashant)
September 2, 2026 17:01
View session
Contributor
Author
|
Hi Sean McManus (@sean-mcmanus), |
Prashant Kumar Rai (8prashant)
requested a review
from Sean McManus (sean-mcmanus)
September 2, 2026 17:08
Sean McManus (sean-mcmanus)
left a comment
Contributor
There was a problem hiding this comment.
The correctness fixes now look sound. One focused test-coverage gap remains for the new event-driven paths.
Contributor
|
Prashant Kumar Rai (@8prashant) FYI, the full Run/Debug feature doesn't work since it relies on compiler info that is returned from the cpptools process, but if you have your tasks.json/launch.json already generated (with the IntelliSense engine enabled for example), then it works. |
Sean McManus (sean-mcmanus)
approved these changes
Sep 3, 2026
Contributor
Author
|
Hi Sean McManus (@sean-mcmanus), thanks for reviewing the PR and for adding the regression coverage. I have confirmed that the requested changes are included, and the latest checks are clean. The PR is approved, but I do not have the merge permission for the upstream repository, so the Merge button is not available to me. Could you please merge PR #14719 when you have a chance? Thanks! |
Sean McManus (sean-mcmanus)
added a commit
that referenced
this pull request
Sep 9, 2026
* Use npm ci in issue workflows (#14702) * Pin the Yarn bootstrap and add SHA-512 lock checksums (#14703) * Add SHA-512 checksums to yarn.lock * Pin the Yarn bootstrap install * Register LLVM component for LLDB-MI (#14704) * Add xobjgen to gitignore (for Linux/Mac). (#14707) * Retry transient Yarn install failures (#14708) * Ensure the language client is always ready before using it (#14617) * Update 1.34.0 changelog (#14710) * Update changelog and version for 1.34.1 (#14714) * Update clang-tidy checks to 23.1.0 (#14713) * Use native file type mappings for TypeScript-side classification (#14711) * Add 1.34.2 changelog (#14722) * Add 1.34.2 changelog * Remove ignored network isolation policy (#14728) * Bump fast-uri from 3.1.5 to 3.1.6 in /ExtensionPack (#14731) Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.5 to 3.1.6. - [Release notes](https://github.com/fastify/fast-uri/releases) - [Commits](fastify/fast-uri@v3.1.5...v3.1.6) --- updated-dependencies: - dependency-name: fast-uri dependency-version: 3.1.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @xmldom/xmldom from 0.8.13 to 0.8.15 in /Extension (#14733) Bumps [@xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.8.13 to 0.8.15. - [Release notes](https://github.com/xmldom/xmldom/releases) - [Changelog](https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md) - [Commits](xmldom/xmldom@0.8.13...0.8.15) --- updated-dependencies: - dependency-name: "@xmldom/xmldom" dependency-version: 0.8.15 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump browserslist from 4.28.1 to 4.28.8 in /Extension (#14732) Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.28.1 to 4.28.8. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](browserslist/browserslist@4.28.1...4.28.8) --- updated-dependencies: - dependency-name: browserslist dependency-version: 4.28.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove unused gulp-sourcemaps dependency (#14729) * Remove unused gulp-sourcemaps dependency * Remove orphaned dependency resolutions * Fix custom configuration provider regression (#14725) * Restore custom configuration provider checks * Ignore empty crash report files (#14730) * Ignore empty crash report files * Preserve pending crash reads across clients * Keep crash writing state for pending reports * Fix fast-uri dependency. (#14735) * Fix fast-uri dependency. * Also for Themes. * Implement session state tracking for "Run and Debug" button when Inte… (#14719) * Implement session state tracking for "Run and Debug" button when IntelliSense is disabled and add corresponding tests * Enhance session state tracking for build and debug by updating folder open status and adding tests * Fix build and debug folder session state tracking * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <[email protected]> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <[email protected]> --------- Co-authored-by: Copilot Autofix powered by AI <[email protected]> Co-authored-by: Sean McManus <[email protected]> * Fix #11263: Make Edit Configurations UI fully theme-aware in custom themes (#14692) * Fix #11263: use theme-aware colors in Edit Configurations UI * Enhance dropdown styling with theme-aware colors in settings UI --------- Co-authored-by: Sean McManus <[email protected]> * Add processFilter for remote attach process selection (#14684) * Add processFilter for remote attach process selection When attaching to a process on a remote target, the process always has to be selected by hand, even though the launch configuration already knows which executable it belongs to. A generated configuration cannot hard-code processId either, because the pid changes on every boot and on every restart of the service, so the picker is the only option. Add an optional processFilter regular expression to the cppdbg attach configuration. When set, it is matched against the label, description and detail of the remote process list: exactly one match attach to that process directly more than one show the picker with only the matching entries no match show the full picker, as before All three fields are considered because the item format depends on the transport: useExtendedRemote reports the user and the full command line in the label, while pipeTransport reports the process name in the label and the command line in the detail. An invalid regular expression is reported instead of being silently ignored. This affects remote attach only (pipeTransport and useExtendedRemote); local attach continues to use program-based matching. Closes #14682 * Extract remote process filtering into a helper Move the matching logic out of RemoteAttachPicker into a standalone function so that it can be unit tested without a VS Code quick pick or a live connection to a remote target. No functional change. * Add unit tests for processFilter matching Cover empty and non-string filter values, matching against label, description and detail, multiple matches, an invalid regular expression, and a regression case ensuring missing fields are not treated as empty strings. --------- Co-authored-by: Adrian Freihofer <[email protected]> Co-authored-by: Sean McManus <[email protected]> * Bump the github-actions group with 2 updates (#14738) Bumps the github-actions group with 2 updates: [github/codeql-action/init](https://github.com/github/codeql-action) and [github/codeql-action/analyze](https://github.com/github/codeql-action). Updates `github/codeql-action/init` from 4.37.7 to 4.37.9 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@ff2f1c6...cdf488f) Updates `github/codeql-action/analyze` from 4.37.7 to 4.37.9 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@ff2f1c6...cdf488f) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.37.9 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: github/codeql-action/analyze dependency-version: 4.37.9 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix localization translation errors (#14737) * Localization - Translated Strings * Fix localization translation errors * Address localization review feedback * Fix localization review feedback --------- Co-authored-by: csigs <[email protected]> * Update changelog for 1.34.3 (#14740) * Update changelog and version for 1.34.4. (#14748) * Enable PR CI for release and insiders (#14751) * Fix localization string import (#14743) * Fix localization string import * Correct conversion cycle translations * Add Run and Debug session state tests (#14736) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Bob Brown <[email protected]> Co-authored-by: Colen Garoutte-Carson <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Prashant Kumar Rai <[email protected]> Co-authored-by: Copilot Autofix powered by AI <[email protected]> Co-authored-by: afreof <[email protected]> Co-authored-by: Adrian Freihofer <[email protected]> Co-authored-by: csigs <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13001
When
C_Cpp.intelliSenseEngineis set to"disabled", the language server client is not started. Previously,cpptools.buildAndDebug.isSourceFileandcpptools.buildAndDebug.isFolderOpencontext keys (which control the visibility of the "Run / Debug C/C++ File" and "Add Debug Configuration" editor action buttons) were only updated within the language server client (client.ts). Consequently, disabling IntelliSense would cause the Run/Debug shortcut buttons to never appear in the editor title bar.This PR updates the Debugger extension initialization (
Debugger/extension.ts) to track active text editor changes and keepbuildAndDebugIsSourceFileandbuildAndDebugIsFolderOpenup to date regardless of whether IntelliSense is enabled or disabled.Changes
updateBuildAndDebugSessionStateand registered anonDidChangeActiveTextEditorlistener inDebuggerExtension.initialize.Extension/test/scenarios/SingleRootProject/tests/buildAndDebug.test.tsverifying session state updates for source files, header files, non-C/C++ files, andundefinededitors.Verification
yarn compile) with 0 errors.yarn test --scenario=SingleRootProjectand verified allBuildAndDebug SessionState Testspass.