Clear diagnostic results on documents - #123

Karthik Nadig (@karthiknadig) would appreciate a look over if you can? more details on the bug

Sam Duke (@samskiter) Thanks for looking into this issue. I have a few questions.
I think a fix would be to track problems in dictionary in both file and workspace scope cases. Use that to clear on a per document basis. what do you think?

I am actually thinking of actually switching this to use a different request: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_pullDiagnostics
As that handles both workspace and file scoped diagnostics and uses a tracking id to refer when it needs to re-check for diagnostics. We will still need a dictionary and tract the problems reported, but this will give us better context on what was reported to the IDE and what the IDE presenting to the user.

For debugging you can actually use the test view to debug specific tests:

Karthik Nadig (@karthiknadig) Agree that the architecture doesn't quite look right for workspace reporting setting - as you point out, this fix would be unable to clear documents that aren't requested directly from the LSP (i.e. those from included documents, the mypy response doesn't include a list of files it scanned it seems)

I believe that the proposed fix would at least remove the most annoying/frustrating aspects of this bug - that you can edit a file and have it go from Red to Green without having to restart the mypy-type-checker server (which is currently in my muscle memory!). It should be fine for the file-level reporting and the workspace reporting scope is still market experimental by you right? So this might be a good stop-gap while you undertake a bigger refactor as you mention (should probably be tracked in a separate ticket, IMO)? WDYT?

I'm going to also have a quick look to see if there's a way to get mypy to give a response for every file it inspected... might make this even easier to fix up?

I agree with this as a stop gap fix.

Created #124 to track the bigger change.

Also raised: python/mypy#15902 which might make implementing this a little easier

@microsoft-github-policy-service agree

Need a Bug label adding please Karthik Nadig (@karthiknadig)

Kartik Raj (@karrtikr) fixed :)

Seems to be still failing.. Did you forget to commit all changes by chance?

i formatted the file with black - which is what I thought was failing

ah, there was a second file that needed formatting. pushed

OK think it's good to go now Anthony Kim (@anthonykim1)

plz can haz review?

Just need 1 more review and then we can merge?

Thanks all! 🥳