Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Travis build is failing #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DonJayamanne opened this issue Nov 29, 2017 · 3 comments · Fixed by #326
Closed

Travis build is failing #323

DonJayamanne opened this issue Nov 29, 2017 · 3 comments · Fixed by #326
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@DonJayamanne
Copy link

Travis build is failing with the following error:
src/test/index.ts(11,5): error TS2345: Argument of type '{ ui: string; useColors: true; timeout: number; retries: number; }' is not assignable to parameter of type 'MochaSetupOptions'. Object literal may only specify known properties, and 'retries' does not exist in type 'MochaSetupOptions'.
@DonJayamanne DonJayamanne added awaiting 2-PR bug Issue identified by VS Code Team member as probable bug labels Nov 29, 2017
@DonJayamanne
Copy link
Author

Mocha supports retries, but the typescript definition files dont. Looks like the definition file (npm dependency) changed, causing the build to fail.

@DonJayamanne
Copy link
Author

Might have to start committing a package-lock.json file.

This was referenced Nov 29, 2017
Closed
Merged
@brettcannon
Copy link
Member

Yes, we should start committing the lock file.

@brettcannon brettcannon modified the milestone: December 2017 Nov 29, 2017
DonJayamanne added a commit that referenced this issue Nov 29, 2017
@DonJayamanne
Fix travis build error (#326)
09df53a 
Fixes #323
Pass options to mocha as an anonymous type as `retries` is not supported in the typed definition file, even though mocha supports it.
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix travis build error DonJayamanne/pythonVSCode
2 participants
@brettcannon @DonJayamanne