Thanks to visit codestin.com
Credit goes to github.com

Skip to content

New workspace virtual environments are not discovered until VS Code reloads #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qubitron opened this issue Jan 29, 2018 · 3 comments
Closed

New workspace virtual environments are not discovered until VS Code reloads #656

qubitron opened this issue Jan 29, 2018 · 3 comments
Assignees
@DonJayamanne
Labels
feature-request Request for new features or functionality
Milestone
2018, week 44 - N...

Comments

@qubitron
Copy link

Environment data

VS Code version: 1.19.3
Python Extension version: 2018.1 Beta
Python Version: Python 3.6
OS and version: Windows 10

Actual behavior

New virtual environments in your workspace root are not shown in the Select Interpreter list until restarting VS code

Expected behavior

New virtual environments within the workspace are shown upon running select interpreter

Steps to reproduce:

  • Created a new virtual environment from the terminal at the workspace root
  • Select interpreter from VS Code
@brettcannon brettcannon added feature-request Request for new features or functionality awaiting 2-PR labels Jan 30, 2018
@thejtshow thejtshow mentioned this issue Mar 10, 2018
Closed
@DonJayamanne DonJayamanne mentioned this issue Sep 13, 2018
Closed
@brettcannon
Copy link
Member

We are going to scope this to just virtual environments created in the workspace folder (should take into consideration the fact that pipenv can create its virtual environment locally when a certain environment variable is set).

@ericsnowcurrently ericsnowcurrently mentioned this issue Sep 20, 2018
Closed
@DonJayamanne DonJayamanne changed the title New virtual environments are not discovered until VS Code resets New workspace virtual environments are not discovered until VS Code reloads Sep 20, 2018
@DonJayamanne
Copy link

DonJayamanne commented Sep 20, 2018 •
edited
Loading

Solution:

  • Add (vscode) file monitor for local workspace
  • If a file/folder is created, and check if we have an interpreter in there
    Use lookForInterpretersInDirectory
  • If there are no interpreters, then get out.
  • If we have an interpreter, then raise an event indicating the fact interpreters need to be refreshed
  • Add a handler for the above event in the CacheableLocatorService
  • In the event handler, clear the map promisesPerResource

@DonJayamanne DonJayamanne mentioned this issue Oct 2, 2018
Closed
@DonJayamanne DonJayamanne mentioned this issue Oct 25, 2018
Merged
5 tasks
@DonJayamanne DonJayamanne self-assigned this Oct 26, 2018
@DonJayamanne DonJayamanne mentioned this issue Oct 30, 2018
Closed
5 tasks
@DonJayamanne DonJayamanne reopened this Oct 31, 2018
@DonJayamanne DonJayamanne mentioned this issue Oct 31, 2018
Merged
3 tasks
DonJayamanne added a commit that referenced this issue Nov 1, 2018
@DonJayamanne
Progress indicator when loading interpreters and speed up detection o…
35ab321 
…f new virtual envs in workspace (#3079)

For #656
When extension is refreshing the list of interpreters, we'll display a progress message Refreshing Python Interpreters
Add a progress label for this.
@brettcannon
Copy link
Member

This doesn't seem to re-trigger if a virtual environment is deleted. Is that expected?

@lock lock bot locked as resolved and limited conversation to collaborators Dec 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
2018, week 44 - Nov sprint 1
Development

No branches or pull requests
3 participants
@brettcannon @DonJayamanne @qubitron