Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Correctly log unit test error logs #10120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2020
Merged

Correctly log unit test error logs #10120

merged 3 commits into from
Feb 18, 2020

Conversation

karrtikr
Copy link

For #2660

@karrtikr karrtikr added the no-changelog No news entry required label Feb 13, 2020
@codecov-io
Copy link

codecov-io commented Feb 13, 2020 •
edited
Loading

Codecov Report

Merging #10120 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10120      +/-   ##
==========================================
+ Coverage    61.2%   61.33%   +0.13%     
==========================================
  Files         564      567       +3     
  Lines       30078    30759     +681     
  Branches     4550     4408     -142     
==========================================
+ Hits        18408    18867     +459     
- Misses      10640    10908     +268     
+ Partials     1030      984      -46
Impacted Files Coverage Δ
src/client/testing/unittest/runner.ts 14.4% <100%> (ø) ⬆️
src/client/common/contextKey.ts 77.77% <0%> (-22.23%) ⬇️
.../client/datascience/context/activeEditorContext.ts 19.04% <0%> (-10.12%) ⬇️
...ugger/debugAdapter/Common/processServiceFactory.ts 41.66% <0%> (-8.34%) ⬇️
...science-ui/interactive-common/latexManipulation.ts 92.59% <0%> (-7.41%) ⬇️
...eter/jupyterCommandInterpreterDependencyService.ts 54.76% <0%> (-7.31%) ⬇️
.../extension/configuration/providers/remoteAttach.ts 85.71% <0%> (-6.6%) ⬇️
.../extension/configuration/providers/moduleLaunch.ts 88.23% <0%> (-5.52%) ⬇️
.../datascience/jupyter/interpreter/jupyterCommand.ts 50% <0%> (-5.24%) ⬇️
...ient/debugger/extension/attachQuickPick/factory.ts 95.23% <0%> (-4.77%) ⬇️
... and 392 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 185d9e2...81a6b5a. Read the comment docs.

ericsnowcurrently
ericsnowcurrently approved these changes Feb 18, 2020
View reviewed changes
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DonJayamanne
DonJayamanne previously requested changes Feb 18, 2020
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 21 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@karrtikr karrtikr merged commit 4f276d2 into microsoft:master Feb 18, 2020
@karrtikr karrtikr deleted the unitlog branch February 18, 2020 22:08
karrtikr pushed a commit that referenced this pull request Feb 18, 2020
Revert "Correctly log unit test error logs (#10120)"
d4b848e 
This reverts commit 4f276d2.
@karrtikr karrtikr mentioned this pull request Feb 18, 2020
Merged
karrtikr pushed a commit that referenced this pull request Feb 18, 2020
Revert "Correctly log unit test error logs (#10120)" (#10187)
88f38ec 
This reverts commit 4f276d2.
@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@kimadeline kimadeline kimadeline approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karrtikr @codecov-io @ericsnowcurrently @DonJayamanne @kimadeline