Fix tests in ds/custom_editor branch #10512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e93f77a.
DonJayamanne
commented
Mar 10, 2020
| customEditorService | ||
| .setup(c => c.openEditor(typemoq.It.isAny())) | ||
| .returns(async f => { | ||
| return registeredProvider.resolveCustomEditor(f, panel.object); | ||
| const doc = typemoq.Mock.ofType<CustomDocument>(); |
DonJayamanne
commented
Mar 10, 2020
| @@ -8,7 +8,9 @@ | |||
| "request": "launch", | |||
| "runtimeExecutable": "${execPath}", | |||
| "args": [ | |||
| "--extensionDevelopmentPath=${workspaceFolder}" | |||
| "--extensionDevelopmentPath=${workspaceFolder}", | |||
There was a problem hiding this comment.
Restored running tests against insiders.
DonJayamanne
commented
Mar 10, 2020
| @@ -24,4 +24,4 @@ export function getOSType() { | |||
| } | |||
| } | |||
|
|
|||
| export const UseCustomEditor = true; | |||
| export const UseCustomEditor = { enabled: true }; | |||
There was a problem hiding this comment.
Are we're supporting both custom and old editors. We need tests for both.
This object allows us to toggle from tests.
There was a problem hiding this comment.
Do we need to support both? Once this ships we're not using the old way anymore.
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## ds/custom_editor #10512 +/- ##
====================================================
+ Coverage 60.8% 60.83% +0.03%
====================================================
Files 579 579
Lines 31301 31303 +2
Branches 4454 4455 +1
====================================================
+ Hits 19032 19043 +11
+ Misses 11308 11293 -15
- Partials 961 967 +6
Continue to review full report at Codecov.
|
rchiodo
approved these changes
Mar 10, 2020
DavidKutu
approved these changes
Mar 10, 2020
DonJayamanne
added a commit
that referenced
this pull request
Mar 17, 2020
* master: Fix merge issue Move redux logging to a different file (#10605) Disable custom editor API (#10604) Ensure local host only if connection not available (#10600) Delegate management of notebooks (creation and disposing) to I… (#10568) Refactor to accommodate upstream VSCode API changes (#10569) Use a single notebook beetween multiple native editors (#10514) Add support for synchronising edits between two nb editors of… (#10189) Fix tests in ds/custom_editor branch (#10512) Fix linter Reimplement custom editor using new API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10510