Copy widget scripts to extension folder #11082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11082 +/- ##
==========================================
- Coverage 61.42% 61.39% -0.03%
==========================================
Files 597 597
Lines 32752 32756 +4
Branches 4631 4631
==========================================
- Hits 20119 20112 -7
- Misses 11617 11626 +9
- Partials 1016 1018 +2
Continue to review full report at Codecov.
|
DavidKutu
approved these changes
Apr 10, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
rchiodo
reviewed
Apr 10, 2020
| ) {} | ||
|
|
||
| // tslint:disable-next-line:no-any | ||
| public async create(options: IWebPanelOptions): Promise<IWebPanel> { | ||
| const serverData = options.startHttpServer | ||
| ? await this.ensureServerIsRunning() | ||
| : { port: undefined, token: undefined }; | ||
|
|
||
| return new WebPanel(this.fs, this.disposableRegistry, serverData.port, serverData.token, options); | ||
| // Allow loading resources from the `<extension folder>/tmp` folder when in webiviews. |
There was a problem hiding this comment.
Hey do you want to fix the 'workspace' root bug while you're changing this?
IanMatthewHuff
approved these changes
Apr 10, 2020
rchiodo
reviewed
Apr 10, 2020
| // Only if original file has been modified should we create a new copy of the sam file. | ||
| const fileHash: string = await this.fs.getFileHash(localResource.fsPath); | ||
| const uniqueFileName = sanitize(sha256().update(`${localResource.fsPath}${fileHash}`).digest('hex')); | ||
| const targetFolder = await this.createTargetWidgetScriptsFolder; |
There was a problem hiding this comment.
Seems like the name here should have 'promise' in it somewhere. looks like you forgot to call a function
rchiodo
reviewed
Apr 10, 2020
| '@jupyter-widgets/controls', | ||
| '@jupyter-widgets/base', | ||
| '@jupyter-widgets/output', | ||
| 'azureml_widgets' |
There was a problem hiding this comment.
Does this work now? Meaning they put the source up on unpkg?
DonJayamanne
added a commit
that referenced
this pull request
Apr 13, 2020
* Copy widget scripts to extension folder * Fix test
DonJayamanne
added a commit
that referenced
this pull request
Apr 14, 2020
* Load widget scripts from CDN and/or local python interpreter (#10987) * Address sonar issues * Fix linter * Fixes * Better way to pas array buffer * Added comments * Oops * Copy widget scripts to extension folder (#11082) * Copy widget scripts to extension folder * Fix test * Remove aml scripts from extension (#11085) * Validate python when nb opened not on extension activates (#11087) For #10893 * Support workspace images in markdown cells (#11086) For #10893 * Fix functional tests for ipywidgets and download just chrome b… (#11093) For #11092 playwright downloads other browsers, we need just one chrome (as this is closest to what VSCode is built upon) * Added tests for k3d widget (#11133) For #10799, #11096 * Fix failing ipywidget tests (#11132) For #11099 * Update change log
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11061