Fixes for UI issues #11130
Merged
Fixes for UI issues #11130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
DavidKutu
approved these changes
Apr 13, 2020
DonJayamanne
approved these changes
Apr 13, 2020
| @@ -488,5 +487,8 @@ collapse-bar controls-div [cell-input, cell-output, markdown-cell- | |||
| } | |||
|
|
|||
| .native-editor-celltoolbar-middle .image-button { | |||
| margin-right: 8px; | |||
| margin-right: 3px; | |||
There was a problem hiding this comment.
Personally I prefer margin: 4px 3px.
| @@ -529,7 +531,10 @@ body, html { | |||
| } | |||
|
|
|||
| .toolbar-menu-bar .image-button { | |||
| margin-right: 12px; | |||
| margin-top: 8px; | |||
Codecov Report
@@ Coverage Diff @@
## master #11130 +/- ##
==========================================
- Coverage 61.47% 61.44% -0.03%
==========================================
Files 597 597
Lines 32801 32801
Branches 4640 4640
==========================================
- Hits 20163 20154 -9
- Misses 11622 11629 +7
- Partials 1016 1018 +2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10464, #10465
Change icon spacing and font for toolbar