Remove unwanted elements from cells when saving. #11164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
DavidKutu
approved these changes
Apr 14, 2020
|
This should also solve #10855 |
Codecov Report
@@ Coverage Diff @@
## master #11164 +/- ##
==========================================
+ Coverage 61.41% 61.43% +0.02%
==========================================
Files 596 596
Lines 32848 32873 +25
Branches 4655 4659 +4
==========================================
+ Hits 20173 20195 +22
+ Misses 12465 11659 -806
- Partials 210 1019 +809
Continue to review full report at Codecov.
|
| @@ -75,4 +77,169 @@ suite('Data Science Tests', () => { | |||
| assert.ok(onDidChangeActiveTextEditor.calledOnce); | |||
| }); | |||
| }); | |||
|
|
|||
| suite('Cell pruning', () => { | |||
There was a problem hiding this comment.
Now this is clearly a good function for unit test. Nice.
| import { noop } from '../common/utils/misc'; | ||
| import { Settings } from './constants'; | ||
|
|
||
| // Can't figure out a better way to do this. Enumerate | ||
| // the allowed keys of different output formats. | ||
| const dummyStreamObj: nbformat.IStream = { |
There was a problem hiding this comment.
We only support notebook format 4, right? This check works, but seems like it could be broken by an older format or a new format change. I think ok for now though.
There was a problem hiding this comment.
I believe it would be okay because the output is either
- run by us, so format 4
- pruned by us if format 3. So if you open a format 3 notebook, and changed it, we'd remove all of the output data that didn't match format 3 (assuming we could open it anywya, which we can't). If we ever supported this, we'd probably import and change to format 4 on open.
IanMatthewHuff
approved these changes
Apr 15, 2020
rchiodo
added a commit
that referenced
this pull request
Apr 15, 2020
* Remove unwanted elements from cells when saving. * Fix a sonar warning * FIx another sonar warning
rchiodo
added a commit
that referenced
this pull request
Apr 15, 2020
* Remove unwanted elements from cells when saving. (#11164) * Remove unwanted elements from cells when saving. * Fix a sonar warning * FIx another sonar warning * Update changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11151
The support of transient data broke our saving of a notebook cell. Make sure to prune all unwanted data when saving.