Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Port fix for transient data in notebooks. #11168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2020
Merged

Port fix for transient data in notebooks. #11168

merged 2 commits into from
Apr 15, 2020

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Apr 15, 2020

Port PR #11164 to release branch and fixup changelog

rchiodo and others added 2 commits April 14, 2020 17:20
@rchiodo
Remove unwanted elements from cells when saving. (#11164)
5199e87 
* Remove unwanted elements from cells when saving.

* Fix a sonar warning

* FIx another sonar warning
@rchiodo
Update changelog
d69a3dd
@rchiodo rchiodo self-assigned this Apr 15, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

DonJayamanne
DonJayamanne approved these changes Apr 15, 2020
View reviewed changes
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat fix

@codecov-io
Copy link

codecov-io commented Apr 15, 2020 •
edited
Loading

Codecov Report

Merging #11168 into release-2020.04 will increase coverage by 0.01%.
The diff coverage is 96.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.04   #11168      +/-   ##
===================================================
+ Coverage            61.39%   61.40%   +0.01%     
===================================================
  Files                  596      596              
  Lines                32786    32808      +22     
  Branches              4642     4644       +2     
===================================================
+ Hits                 20128    20145      +17     
- Misses               11640    11643       +3     
- Partials              1018     1020       +2
Impacted Files Coverage Δ
...tascience/interactive-ipynb/nativeEditorStorage.ts 48.93% <50.00%> (+0.45%) ⬆️
src/client/datascience/common.ts 100.00% <100.00%> (ø)
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02fa068...d69a3dd. Read the comment docs.

@rchiodo rchiodo merged commit 15c68db into release-2020.04 Apr 15, 2020
@rchiodo rchiodo deleted the rchiodo/rel_transient branch April 15, 2020 15:46
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

Assignees

@rchiodo rchiodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rchiodo @codecov-io @DonJayamanne