-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Non-jupyter kernel finder #11538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-jupyter kernel finder #11538
Conversation
Creating this as a draft pull request first. I have more cleanup to do and tests to add, but I wanted to throw this out for comment first before digging in there to see if the basic algorithm seems solid. This current code works when I did some basic sniff testing on it. Ideas that I'm working with:
|
Codecov Report
@@ Coverage Diff @@
## master #11538 +/- ##
==========================================
+ Coverage 60.45% 60.57% +0.11%
==========================================
Files 618 619 +1
Lines 33774 33889 +115
Branches 4763 4780 +17
==========================================
+ Hits 20419 20527 +108
+ Misses 12347 12345 -2
- Partials 1008 1017 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two issues are blocking for me, others are completely optional comments.
- I'd like to see
cancelToken
not being passed into a private method (explained) - Might want to remove hardcoding of
/
in glob search (not sure it will work on windows, either way, better to avoid hardcoding).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops just realized theres an issue with foreach.
Thanks for taking a look Don. Much appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos, SonarCloud Quality Gate passed!
|
Single Workspace is just timeout. |
For #
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).