Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Poetry interpreter support #11839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Poetry interpreter support #11839

wants to merge 8 commits into from

Conversation

terricain
Copy link

@terricain terricain commented May 15, 2020 •
edited
Loading

Sorta wrote the PR before raising an issue and realised one is required :D

Don't really know typescript so would not be surprised if there is a better way to do this. Pretty much just mirrored the pipenv support as poetry is similar

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@msftclas
Copy link

msftclas commented May 15, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

codecov-io commented May 15, 2020 •
edited
Loading

Codecov Report

Merging #11839 into master will increase coverage by 0.03%.
The diff coverage is 73.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11839      +/-   ##
==========================================
+ Coverage   60.45%   60.48%   +0.03%     
==========================================
  Files         631      632       +1     
  Lines       34156    34282     +126     
  Branches     4798     4822      +24     
==========================================
+ Hits        20648    20736      +88     
- Misses      12508    12535      +27     
- Partials     1000     1011      +11
Impacted Files Coverage Δ
src/client/common/process/types.ts 84.61% <ø> (ø)
...c/client/interpreter/autoSelection/rules/system.ts 100.00% <ø> (ø)
src/client/interpreter/helpers.ts 48.19% <0.00%> (-0.59%) ⬇️
src/client/interpreter/locators/index.ts 86.27% <ø> (ø)
src/client/telemetry/index.ts 85.21% <ø> (ø)
src/client/interpreter/virtualEnvs/index.ts 75.00% <25.00%> (-7.93%) ⬇️
...ent/interpreter/locators/services/poetryService.ts 77.00% <77.00%> (ø)
src/client/interpreter/locators/helpers.ts 70.68% <77.77%> (+0.10%) ⬆️
src/client/common/utils/localize.ts 95.59% <100.00%> (+0.01%) ⬆️
src/client/interpreter/contracts.ts 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 974e784...1f829f8. Read the comment docs.

@terricain terricain changed the title Poetry interpreter support WIP: Poetry interpreter support May 15, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@terricain terricain changed the title WIP: Poetry interpreter support Poetry interpreter support May 15, 2020
@terricain
Copy link
Author

Woot tests are passing 😄

@DonJayamanne
Copy link

I tried working on this, #9399
But closed it as we're in the process of making some architectural changes hence closed my original PR.
@karthiknadig What's the plan here? I closed mine as i figured it would be a waste.

@karthiknadig
Copy link
Member

We will revisit this after making the architecture change. One of the intents with the change we have planed is to make it easier to add support for this. Also, have better control over what we can turn on or off when it comes to searching.

@terricain
Copy link
Author

:D fair enough, I'll leave this here until you've made said changes

@microsoft-github-updates microsoft-github-updates bot changed the base branch from master to main September 3, 2020 21:07
@brettcannon
Copy link
Member

As the restructuring is pretty extensive and this PR has drifted due to merge conflicts, I'm closing this as out of date. But I will say we do still plan to add Poetry support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@terricain @msftclas @codecov-io @DonJayamanne @karthiknadig @brettcannon