Get more nightly tests to pass #11881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
May 18, 2020
| @@ -0,0 +1,22 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
| // Licensed under the MIT License. | |||
| import { injectable } from 'inversify'; | |||
There was a problem hiding this comment.
Note, this file will only be added to the loggers during testing. It simply logs the cell execution.
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -592,7 +592,7 @@ suite('FileSystem', () => { | |||
|
|
|||
| suite('createWriteStream', () => { | |||
| test('wraps the low-level impl', async () => { | |||
| const filename = await fix.resolve('x/y/z/spam.py'); | |||
| const filename = await fix.resolve('x/y/z/spam2.py'); | |||
There was a problem hiding this comment.
Sorry, this test is randomly failing. Been trying to figure out why. Near as I can tell is that the file exists when it shouldn't (read test is interfering with the write test).
I can't repro locally, but I figured I'd try this instead of just disabling the test.
IanMatthewHuff
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get more nightly tests to pass and add more logging.