Actually fix user settings for jediEnabled.
#12433
Conversation
|
LGTM but a core member may want to look. |
|
Noticed one thing now that this code is actually running. If you have a bunch of comments in a run-up to the old // Some
// Comments
// To keep
"python.jediEnabled": false,Will be removed entirely. |
|
Hmm, I guess it's a known issue with the JSONC parser: microsoft/node-jsonc-parser#10 VS Code doesn't use this lib anymore as far as I know (in favor of some internal settings management), so it's difficult to do this sort of change here with files (rather than setting things via VS Code's APIs). |
There was a problem hiding this comment.
Per discussion with Karthik, I think we should remove the block of code that removes jediEnabled. Leaving jediEnabled isn't harmful as the setting is no longer read, and we won't unexpectedly modify a user's settings.json file. In a future release, we can clean up the jediEnabled setting if need be.
@MikhailArkhipov could you remove that block?
|
Sure, although opener of #12429 wanted it removed I think. |
|
I think the main problem was that none of this code was active, so the effect was to not actually move people over to the |
|
Kudos, SonarCloud Quality Gate passed!
|
* Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal
* Actually fix user settings for `jediEnabled`. (#12433) * Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Prapare for point release Co-authored-by: Mikhail Arkhipov <[email protected]>
For #12429
Add
jediEnabledto the search inside content of settings files.- [ ] Has telemetry for enhancements.- [ ] Test plan is updated as appropriate.- [ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).- [ ] The wiki is updated with any design decisions/details.