Fixed bug in exporting notebook to HTML #12464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some notebooks that contain special lines or cells that cause NBConvert to fail to export them. If you'd like an example of such notebook I've attached a link to one. Previously when attempting to export this notebooks no error message would be displayed. In other words, I had not handled some edge cases where the export fails in one specific method (check files to see where). This PR simply handles the case where the export fails and displays the appropriate error message to the user.
Link to download notebook you can use to Repro: https://microsoft.sharepoint.com/teams/python/Shared%20Documents/test%20.ipynb%20notebooks/Core_Learning_Algorithms.ipynb
Simply open the notebook and try to export it to .html (you will need the latest master branch changes).
Has telemetry for enhancements.Unit tests & system/integration tests are added/updated.Test plan is updated as appropriate.package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).The wiki is updated with any design decisions/details.