Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Disable flakey CI test #13346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Aug 7, 2020

This change is to disable this test so that CI passes and we can generate an insiders build.

I added this bug here: #13345 to fix the test later.

@rchiodo rchiodo added the no-changelog No news entry required label Aug 7, 2020
@rchiodo rchiodo self-assigned this Aug 7, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2020

Codecov Report

Merging #13346 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13346      +/-   ##
==========================================
- Coverage   59.75%   59.72%   -0.03%     
==========================================
  Files         670      670              
  Lines       37303    37303              
  Branches     5296     5296              
==========================================
- Hits        22290    22281       -9     
- Misses      13878    13884       +6     
- Partials     1135     1138       +3     
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df5ef4...bfd6fbc. Read the comment docs.

@IanMatthewHuff
Copy link
Member

Generally I'm not a nag mail fan. But maybe we need something that sends mail / Teams messages when a test has failed for X number of CI runs. Or maybe just generally when it has been X amount of time since an insiders build has been generated.

@rchiodo
Copy link
Author

rchiodo commented Aug 7, 2020

Generally I'm not a nag mail fan. But maybe we need something that sends mail / Teams messages when a test has failed for X number of CI runs. Or maybe just generally when it has been X amount of time since an insiders build has been generated.

Brett does have something that sends team messages on failures (well actually every build). It might be too chatty though.

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw the test failure isn't flaky, it's failing everytime after the merge of #13246

@rchiodo rchiodo merged commit 19ece5d into master Aug 7, 2020
@rchiodo rchiodo deleted the rchiodo/disable_multiple_linter_test branch August 7, 2020 18:01
IanMatthewHuff pushed a commit to IanMatthewHuff/vscode-python that referenced this pull request Aug 7, 2020
@IanMatthewHuff IanMatthewHuff mentioned this pull request Aug 7, 2020
10 tasks
IanMatthewHuff added a commit that referenced this pull request Aug 7, 2020
karthiknadig added a commit that referenced this pull request Aug 24, 2020
* Port gather survey and icon getting disabled while gathering (#13296)

* Add gather status bar and update survey link (#13225)

* add status bar

* add localization

* Added news file

* add a 2 second timeout

* updated the gather survey link

* Change the gather icon while gathering

* moved the gathering redux function to
interactive common
added a constant

* move css to common.css

* removed the status bar message

* changed noop import

* update changelog

* Disable test (#13346) (#13350)

Co-authored-by: Rich Chiodo <[email protected]>

* Add cell navigation commands as well as a default set of keyboard bindings for most new interactive window cell commands (#13334) (#13348)

* Add Goto Prev/Next Cell

* Add goto previous cell

* Remove unneeded changes

* Add default keybindings for cell commands

* Goto should be Go to

Co-authored-by: Jim Griesmer <[email protected]>

Co-authored-by: Jim Griesmer <[email protected]>

* Autoscroll when extending cell select (#13353) (#13354)

Code change can only affect new keyboard shortcut operations

* Update Release branch for August Release (#13401)

* update version number and npm install to update package-lock.json

* update changelog version and date

* update news for changelog.md

* update generated TPN

Co-authored-by: Ian Huff <[email protected]>

* Update version and change log for bug fix release (#13537)

* Update LSP to latest to resolve problems with LS settings  (#13511)

* Fix path

* Actually fix settings

* Add news

* Add test

* Format

* Suppress 'jediEnabled' removal

* Drop survey first launch threshold

* Update LSP to fix issue with settings in MPLS v1

* Add telemetry for `switch to Pylance` acceptance (#13526)

* Fix path

* Actually fix settings

* Add news

* Add test

* Format

* Suppress 'jediEnabled' removal

* Drop survey first launch threshold

* Initial

* Add test

* PR feedback

* Rename property

* Rename constant

* Define property

* Moar rename

* casing

* Update version and changelogs

* Show status of Jupyter server (Connected/Disconnected) when the user hovers over the status icon (#13544)

* Update change log with more cherry picks

Co-authored-by: Mikhail Arkhipov <[email protected]>
Co-authored-by: Shantnu Suman <[email protected]>

* Remove files that we have consumed in change log

* Fix merge.

Co-authored-by: David Kutugata <[email protected]>
Co-authored-by: Ian Huff <[email protected]>
Co-authored-by: Rich Chiodo <[email protected]>
Co-authored-by: Jim Griesmer <[email protected]>
Co-authored-by: Jim Griesmer <[email protected]>
Co-authored-by: Ian Huff <[email protected]>
Co-authored-by: Mikhail Arkhipov <[email protected]>
Co-authored-by: Shantnu Suman <[email protected]>
karthiknadig added a commit that referenced this pull request Sep 8, 2020
* Port gather survey and icon getting disabled while gathering (#13296)

* Add gather status bar and update survey link (#13225)

* add status bar

* add localization

* Added news file

* add a 2 second timeout

* updated the gather survey link

* Change the gather icon while gathering

* moved the gathering redux function to
interactive common
added a constant

* move css to common.css

* removed the status bar message

* changed noop import

* update changelog

* Disable test (#13346) (#13350)

Co-authored-by: Rich Chiodo <[email protected]>

* Add cell navigation commands as well as a default set of keyboard bindings for most new interactive window cell commands (#13334) (#13348)

* Add Goto Prev/Next Cell

* Add goto previous cell

* Remove unneeded changes

* Add default keybindings for cell commands

* Goto should be Go to

Co-authored-by: Jim Griesmer <[email protected]>

Co-authored-by: Jim Griesmer <[email protected]>

* Autoscroll when extending cell select (#13353) (#13354)

Code change can only affect new keyboard shortcut operations

* Update Release branch for August Release (#13401)

* update version number and npm install to update package-lock.json

* update changelog version and date

* update news for changelog.md

* update generated TPN

Co-authored-by: Ian Huff <[email protected]>

* Update version and change log for bug fix release (#13537)

* Update LSP to latest to resolve problems with LS settings  (#13511)

* Fix path

* Actually fix settings

* Add news

* Add test

* Format

* Suppress 'jediEnabled' removal

* Drop survey first launch threshold

* Update LSP to fix issue with settings in MPLS v1

* Add telemetry for `switch to Pylance` acceptance (#13526)

* Fix path

* Actually fix settings

* Add news

* Add test

* Format

* Suppress 'jediEnabled' removal

* Drop survey first launch threshold

* Initial

* Add test

* PR feedback

* Rename property

* Rename constant

* Define property

* Moar rename

* casing

* Update version and changelogs

* Show status of Jupyter server (Connected/Disconnected) when the user hovers over the status icon (#13544)

* Update change log with more cherry picks

Co-authored-by: Mikhail Arkhipov <[email protected]>
Co-authored-by: Shantnu Suman <[email protected]>

* Update changelog and version for point release. (#13610)

* Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. (#13600)

* Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing (#13554)

* Update vscode-tas-client
* Add experiment group enum
* Add method to retrieve experiment values
* Implementation + tests
* News file
* Update wording of the news entry
* Add telemetry
* More tests
* No opting-in and out of this one
* Don't fetch value if opted out, add tests
* Address comments

* Fix save on close (#13567)

* Pass model through command instead of URI in order to use directly

* Add a test to verify we don't regress

* Finish fixing tests

* Add news entry

* Fix unit tests

* Update changelog and version for point release.

* Change date.

* Format using latest black (#13625)

Co-authored-by: Shantnu Suman <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
Co-authored-by: Rich Chiodo <[email protected]>

* Skip flaky virtual env tests (#13650)

* Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. (#13600)

* Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing (#13554)

* Update vscode-tas-client
* Add experiment group enum
* Add method to retrieve experiment values
* Implementation + tests
* News file
* Update wording of the news entry
* Add telemetry
* More tests
* No opting-in and out of this one
* Don't fetch value if opted out, add tests
* Address comments

* Fix save on close (#13567)

* Pass model through command instead of URI in order to use directly

* Add a test to verify we don't regress

* Finish fixing tests

* Add news entry

* Fix unit tests

* Update changelog and version for point release.

* Skip workspace virtual env service tests

* Add link to issue for skipping

Co-authored-by: Shantnu Suman <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
Co-authored-by: Rich Chiodo <[email protected]>

* Cherry picks, change log, and version update for point release. (#13666)

* Add install telemetry (#13653)

* Add extension install telemetry.

* Add tests.

* Fix typo

* Fix tests.

* Update comment to reflect what the installed actually does.

* Update change log and version for point release.

* Cherry pick history bug for Azure ML CI && Make Jupyter server clickable (#13712)

* Fix: Getting an error on selecting an existing CI which has a display name from the historical CI's in the quick picks (#13642)

* Make Jupyter Server name clickale to select Jupyter server (#13657)

* Update Changelog and remove news files

* Update package version. (#13748)

* Update and pin LSP libraries for new APIs (#13725) (#13756)

Co-authored-by: Jake Bailey <[email protected]>

* PORT showStartPage setting fix (#13706) (#13758)

* fix showStartPage setting on configSettings.ts (#13706)

* fix showStartPage setting on configSettings.ts

* add news file

* Fix unit tests

* oops

* update changelog

* Fix merge issues

* Clean up news

Co-authored-by: David Kutugata <[email protected]>
Co-authored-by: Ian Huff <[email protected]>
Co-authored-by: Rich Chiodo <[email protected]>
Co-authored-by: Jim Griesmer <[email protected]>
Co-authored-by: Jim Griesmer <[email protected]>
Co-authored-by: Ian Huff <[email protected]>
Co-authored-by: Mikhail Arkhipov <[email protected]>
Co-authored-by: Shantnu Suman <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
Co-authored-by: Jake Bailey <[email protected]>
karthiknadig added a commit that referenced this pull request Sep 14, 2020
* Port gather survey and icon getting disabled while gathering (#13296)

* Add gather status bar and update survey link (#13225)

* add status bar

* add localization

* Added news file

* add a 2 second timeout

* updated the gather survey link

* Change the gather icon while gathering

* moved the gathering redux function to
interactive common
added a constant

* move css to common.css

* removed the status bar message

* changed noop import

* update changelog

* Disable test (#13346) (#13350)

Co-authored-by: Rich Chiodo <[email protected]>

* Add cell navigation commands as well as a default set of keyboard bindings for most new interactive window cell commands (#13334) (#13348)

* Add Goto Prev/Next Cell

* Add goto previous cell

* Remove unneeded changes

* Add default keybindings for cell commands

* Goto should be Go to

Co-authored-by: Jim Griesmer <[email protected]>

Co-authored-by: Jim Griesmer <[email protected]>

* Autoscroll when extending cell select (#13353) (#13354)

Code change can only affect new keyboard shortcut operations

* Update Release branch for August Release (#13401)

* update version number and npm install to update package-lock.json

* update changelog version and date

* update news for changelog.md

* update generated TPN

Co-authored-by: Ian Huff <[email protected]>

* Update version and change log for bug fix release (#13537)

* Update LSP to latest to resolve problems with LS settings  (#13511)

* Fix path

* Actually fix settings

* Add news

* Add test

* Format

* Suppress 'jediEnabled' removal

* Drop survey first launch threshold

* Update LSP to fix issue with settings in MPLS v1

* Add telemetry for `switch to Pylance` acceptance (#13526)

* Fix path

* Actually fix settings

* Add news

* Add test

* Format

* Suppress 'jediEnabled' removal

* Drop survey first launch threshold

* Initial

* Add test

* PR feedback

* Rename property

* Rename constant

* Define property

* Moar rename

* casing

* Update version and changelogs

* Show status of Jupyter server (Connected/Disconnected) when the user hovers over the status icon (#13544)

* Update change log with more cherry picks

Co-authored-by: Mikhail Arkhipov <[email protected]>
Co-authored-by: Shantnu Suman <[email protected]>

* Update changelog and version for point release. (#13610)

* Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. (#13600)

* Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing (#13554)

* Update vscode-tas-client
* Add experiment group enum
* Add method to retrieve experiment values
* Implementation + tests
* News file
* Update wording of the news entry
* Add telemetry
* More tests
* No opting-in and out of this one
* Don't fetch value if opted out, add tests
* Address comments

* Fix save on close (#13567)

* Pass model through command instead of URI in order to use directly

* Add a test to verify we don't regress

* Finish fixing tests

* Add news entry

* Fix unit tests

* Update changelog and version for point release.

* Change date.

* Format using latest black (#13625)

Co-authored-by: Shantnu Suman <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
Co-authored-by: Rich Chiodo <[email protected]>

* Skip flaky virtual env tests (#13650)

* Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. (#13600)

* Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing (#13554)

* Update vscode-tas-client
* Add experiment group enum
* Add method to retrieve experiment values
* Implementation + tests
* News file
* Update wording of the news entry
* Add telemetry
* More tests
* No opting-in and out of this one
* Don't fetch value if opted out, add tests
* Address comments

* Fix save on close (#13567)

* Pass model through command instead of URI in order to use directly

* Add a test to verify we don't regress

* Finish fixing tests

* Add news entry

* Fix unit tests

* Update changelog and version for point release.

* Skip workspace virtual env service tests

* Add link to issue for skipping

Co-authored-by: Shantnu Suman <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
Co-authored-by: Rich Chiodo <[email protected]>

* Cherry picks, change log, and version update for point release. (#13666)

* Add install telemetry (#13653)

* Add extension install telemetry.

* Add tests.

* Fix typo

* Fix tests.

* Update comment to reflect what the installed actually does.

* Update change log and version for point release.

* Cherry pick history bug for Azure ML CI && Make Jupyter server clickable (#13712)

* Fix: Getting an error on selecting an existing CI which has a display name from the historical CI's in the quick picks (#13642)

* Make Jupyter Server name clickale to select Jupyter server (#13657)

* Update Changelog and remove news files

* Update package version. (#13748)

* Update and pin LSP libraries for new APIs (#13725) (#13756)

Co-authored-by: Jake Bailey <[email protected]>

* PORT showStartPage setting fix (#13706) (#13758)

* fix showStartPage setting on configSettings.ts (#13706)

* fix showStartPage setting on configSettings.ts

* add news file

* Fix unit tests

* oops

* update changelog

* Fixes for point release (#13841)

* Use 'main' branch for experiments.

* Update changelog and versions

* Update CHANGELOG.md

* Replace 'master' with 'main' in readme (#13845)

Co-authored-by: David Kutugata <[email protected]>
Co-authored-by: Ian Huff <[email protected]>
Co-authored-by: Rich Chiodo <[email protected]>
Co-authored-by: Jim Griesmer <[email protected]>
Co-authored-by: Jim Griesmer <[email protected]>
Co-authored-by: Ian Huff <[email protected]>
Co-authored-by: Mikhail Arkhipov <[email protected]>
Co-authored-by: Shantnu Suman <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
Co-authored-by: Jake Bailey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants