Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix test in CI #13368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Aug 10, 2020
Merged

Fix test in CI #13368

merged 20 commits into from
Aug 10, 2020

Conversation

MikhailArkhipov
Copy link

@MikhailArkhipov MikhailArkhipov commented Aug 10, 2020

For #13345

Fix test in CI. Change configuration target of languageServer to workspace.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.

- [ ] Has a news entry file (remember to thank yourself!).
- [ ] Appropriate comments and documentation strings in the code.
- [ ] Has sufficient logging.
- [ ] Has telemetry for enhancements.
- [ ] Unit tests & system/integration tests are added/updated.
- [ ] Test plan is updated as appropriate.
- [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
- [ ] The wiki is updated with any design decisions/details.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2020

Codecov Report

Merging #13368 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13368      +/-   ##
==========================================
- Coverage   59.71%   59.69%   -0.03%     
==========================================
  Files         670      670              
  Lines       37338    37338              
  Branches     5307     5307              
==========================================
- Hits        22298    22289       -9     
- Misses      13905    13911       +6     
- Partials     1135     1138       +3     
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/datascience/crossProcessLock.ts 79.41% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e62824...cb84443. Read the comment docs.

@MikhailArkhipov MikhailArkhipov merged commit 793acf1 into microsoft:master Aug 10, 2020
@MikhailArkhipov MikhailArkhipov deleted the ci branch August 17, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants