Fix raw kernel disposed problem #13373
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13373 +/- ##
==========================================
- Coverage 59.71% 59.68% -0.04%
==========================================
Files 670 670
Lines 37338 37342 +4
Branches 5307 5308 +1
==========================================
- Hits 22298 22289 -9
- Misses 13905 13915 +10
- Partials 1135 1138 +3
Continue to review full report at Codecov.
|
| @@ -825,6 +825,11 @@ export abstract class InteractiveBase extends WebViewHost<IInteractiveWindowMapp | |||
| } | |||
|
|
|||
| protected async ensureConnectionAndNotebook(): Promise<void> { | |||
| // Start over if we somehow end up with a disposed notebook. | |||
| if (this._notebook && this._notebook.disposed) { | |||
There was a problem hiding this comment.
Seem good. Just reset if the notebook was disposed. So it was one of those situations where a ipynb was opened twice?
There was a problem hiding this comment.
Yeah I was trying to validate a fix you made about causing files to be locked out and got the same file to open multiple times. When I tried to run it, I got this error.
|
Kudos, SonarCloud Quality Gate passed!
|
Finally got this to repro randomly (Direct Kernel disconnected). It seems this can occur if the editor or interactive window is holding onto a disposed notebook when multiple copies of the same file are opened and you close one.
Multiple copies of an editor opening is hard to repro though.