Ensure working directory is an actual directory #13403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
Aug 12, 2020
| @@ -51,7 +55,7 @@ export class PythonKernelLauncherDaemon implements IDisposable { | |||
| // If we don't have a KernelDaemon here then we have an execution service and should use that to launch | |||
| const observableOutput = daemon.execModuleObservable(moduleName, moduleArgs, { | |||
| env, | |||
| cwd: workingDirectory | |||
| cwd: wdExists ? workingDirectory : process.cwd() | |||
There was a problem hiding this comment.
This isn't really necessary but just wanted to double check.
Codecov Report
@@ Coverage Diff @@
## master #13403 +/- ##
==========================================
- Coverage 59.94% 59.90% -0.05%
==========================================
Files 670 670
Lines 37186 37208 +22
Branches 5309 5312 +3
==========================================
- Hits 22293 22288 -5
- Misses 13771 13780 +9
- Partials 1122 1140 +18
Continue to review full report at Codecov.
|
| assert.ok(interruptedKernel, 'Kernel was not interrupted'); | ||
| } else { | ||
| // Timing is too iffy for real jupyter. However we really just | ||
| // want to make sure double interrupt is supported so keep the |
IanMatthewHuff
approved these changes
Aug 12, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the nightly flake hover test. Caused by my changes to set the working directory.
HA! Caught another bug with our functional tests. I love it when that happens.