Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use a more forgiving comparer when comparing version #15912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2021

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Apr 9, 2021

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we add and fix tests. Also we should move

export function sortInterpreters(interpreters: PythonEnvironment[]): PythonEnvironment[] {

out of the file (where we store old code which will go away), and place it next to where it's used

const sorted = sortInterpreters(interpreters);

@karthiknadig karthiknadig added the no-changelog No news entry required label Apr 12, 2021
@karthiknadig karthiknadig marked this pull request as ready for review April 12, 2021 19:36
@karthiknadig karthiknadig requested a review from karrtikr April 13, 2021 16:03
@karthiknadig karthiknadig merged commit d1f2d70 into microsoft:main Apr 13, 2021
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Apr 13, 2021
* Use a more forgiving comparer when comparing version

* Update tests

* Move sort interpreters function
karthiknadig added a commit that referenced this pull request Apr 13, 2021
* Use a more forgiving comparer when comparing version

* Update tests

* Move sort interpreters function
@karthiknadig karthiknadig deleted the compare-version branch April 20, 2021 19:05
karthiknadig added a commit that referenced this pull request Apr 20, 2021
* Do not run `poetry env info -p` to get the type for local poetry environment (#15898)

* Do not run poetry env info -p to get the type for local poetry environment, get best effort type instead

* Update src/test/pythonEnvironments/common/envlayouts/poetry/project4/pyproject.toml

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>

* Handle both API versions (#15932) (#15936)

* Correct a news item (#15904)

* Use a more forgiving comparer when comparing version (#15912)

* Use a more forgiving comparer when comparing version

* Update tests

* Move sort interpreters function

* Wrap yields with a try catch (#15931)

* Log parsing errors in verbose mode only

* Fix conda logging

* Wrap yields with try catch

* Updating the version, change-log, and TPN for release (#15989)

* Update TensorBoard launcher script to not use deprecated API (#15991)

Co-authored-by: Kartik Raj <[email protected]>
Co-authored-by: Ian Huff <[email protected]>
Co-authored-by: Joyce Er <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants