Fix Pylance Python 2 mistake #16246
Merged
Fix Pylance Python 2 mistake #16246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimadeline
approved these changes
May 14, 2021
|
Not sure if I should be doing something with news here, given it's a fix to a fix so it actually works. This code already doesn't have tests, I don't think. 😬 |
karthiknadig
approved these changes
May 14, 2021
|
No need to worry about the news. I will take care of it. |
karthiknadig
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
May 14, 2021
karthiknadig
pushed a commit
that referenced
this pull request
May 14, 2021
karthiknadig
added a commit
that referenced
this pull request
May 18, 2021
* Cherry-picks into release from main (#16181) * Update pygls dependency (#16165) * Upgrade all packages (#16180) * Update release version (#16196) * Update change log version * Allow Pylance to be used with Python 2 if explicitly chosen (#16210) (#16214) * Update version and change log. (#16237) * Fix Pylance Python 2 mistake (#16246) * Update version and change log for second point release Co-authored-by: Jake Bailey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake in #16210 by flipping the condition. My comment was right, but the code actually went and applied the rule to people who explicitly set the setting, versus those who did not.
I think I oopsed because in an early revision, I wasn't tracking "is default", but "is explicitly set". Maybe the latter would have made more sense.