Remove deprecated setting usage in DS smoke test #16491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
approved these changes
Jun 16, 2021
karthiknadig
added a commit
that referenced
this pull request
Jun 21, 2021
* Recommend >= 0.2.0 of `torch-tb-profiler` (#16440) * Recommend >= 0.2.0 of torch-tb-profiler * Update CHANGELOG.md and delete news * Prep for trusted workspaces work (#16485) * Implement python.defaultInterpreterPath in workspace scope * Move DeprecatePythonPath experiment to new framework and retire old framework * Remove execution isolation script * Do not delete old user setting while migrating interpreter settings * Modify the python path deprecation prompt * Add deprecate pythonPath doc in package.json * Add default Interpreter path entry at the bottom of the interpreter list * Update VSCode engine to 1.57 * Restore Deprecate PythonPath experiment for compatibility * Remove environments security related to discovery (#17) * Remove environments security related to autoselection (#18) * Fix ESLint errors related to security undo work * Add experiment to package.json * Edit changelog to include enhancement details * Delete news entry * Update release candidate for release (#16490) * Update change log * Update version * Update TPN * Remove deprecated setting usage in DS smoke test (#16491) Co-authored-by: Joyce Er <[email protected]> Co-authored-by: Kartik Raj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #16440 (comment)
This isn't the only part of the smoke tests that needs updating. In the interest of not perturbing the release branch too much I'm just removing the minimum amount of code required to get CI green again.