Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix testing with python 3.10 #18127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 7, 2021
Merged

Conversation

karthiknadig
Copy link
Member

No description provided.

@karthiknadig karthiknadig added the no-changelog No news entry required label Dec 6, 2021
@karthiknadig karthiknadig self-assigned this Dec 6, 2021
@@ -9,7 +9,7 @@ pylint
pycodestyle
pydocstyle
prospector ; python_version > '2.7'
pytest<6 ; python_version > '2.7' # Tests currently fail against pytest 6.
pytest ; python_version > '2.7'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought our Python tests were failing on pytest 6, what is this magic?!

@@ -9,7 +9,7 @@ on:

env:
NODE_VERSION: 12.15.0
PYTHON_VERSION: 3.9
PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know whether to 😆 or to 😭

@karthiknadig karthiknadig merged commit e382d86 into microsoft:main Dec 7, 2021
@karthiknadig karthiknadig deleted the fix-test-310 branch December 7, 2021 02:51
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
* Fix testing with python 3.10

* Update build workflow to use the latest python

* Fix YML problem

* Disable tensor board session tests for 3.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants