@karrtikr are the tests good? - I have never wrote a test before.

@karrtikr I have changed the tests so this should be ready for review - I am justing importing from vscode for the IAppShell window parameter. If I have to change that, it is no problem.

@karrtikr I have also attempted to solve #18455 and #18462

Please do not fix multiple issues in the same PR; it should be one PR per issue.

I also just realized you did not follow https://github.com/microsoft/vscode-python/wiki/Submitting-a-pull-request#creating-a-pull-request and opened an issue first about what you're trying to change (which also says you should open one PR per issue).

Please read the development docs in our wiki before proceeding with this or any other PRs.

I have never wrote a test before.

I would advise reading up on software development to understand how to do testing, code organization/structure (e.g. when to write a class and when to write a function), etc. Our admittedly complicated code base may not be the best place to start with open source contributions if you still learning how to write tests.

I will close this as the problem has been solved