Revert to using conda activate for fetching activated environment variables
#19819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
approved these changes
Sep 12, 2022
eleanorjboyd
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Oct 4, 2022
…ariables (microsoft#19819) Because of conda/conda#11814, `conda activate` is faster. Closes microsoft#19347 For microsoft#19101
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…ariables (microsoft/vscode-python#19819) Because of conda/conda#11814, `conda activate` is faster. Closes microsoft/vscode-python#19347 For microsoft/vscode-python#19101
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…les (microsoft/vscode-python#19986) Reverts microsoft/vscode-python#19819 Closes microsoft/vscode-python#19967 Until we have a better activation story: microsoft/vscode-python#11039, where we potentially get rid of using `conda activate` commands, use `conda run` for fetching environment variables even though it's slower. Created microsoft/vscode-python#19987 for tackling it in the future. FYI @DonJayamanne
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of conda/conda#11814,
conda activateis faster.Closes #19347 For #19101