Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PYTHONSTARTUP should be injected regardless of terminalEnv experiment #25037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025

Conversation

anthonykim1
Copy link

Resolve: #25013

Python shell integration env var injection via env var collection was getting cleared undesirable, when user had opted out of terminal env var experiment.

We want to inject PYTHONSTARTUP regardless of the experiment, depending on user setting.

@anthonykim1 anthonykim1 added this to the May 2025 milestone May 5, 2025
@anthonykim1 anthonykim1 self-assigned this May 5, 2025
@anthonykim1 anthonykim1 added bug Issue identified by VS Code Team member as probable bug area-terminal labels May 5, 2025
@anthonykim1 anthonykim1 marked this pull request as draft May 5, 2025 23:18
@anthonykim1
Copy link
Author

anthonykim1 commented May 5, 2025

Problem summary

  • PYTHONSTARTUP was getting injected, but was getting cleared undesirably conditionally on env var experiment state.

@anthonykim1 anthonykim1 changed the title PYTHONSTARTUP should be injected regardless of pythonTerminalEnv Experiment PYTHONSTARTUP should be injected regardless of terminalEnv experiment May 5, 2025
@anthonykim1 anthonykim1 marked this pull request as ready for review May 6, 2025 16:29
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@anthonykim1 anthonykim1 merged commit 0317c6b into microsoft:main May 6, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PYTHONSTARTUP is not injected when terminal env experiment is off
2 participants