Prefer using Notebook tools over Python tools for notebooks #25098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ools for Notebooks
DonJayamanne
commented
May 21, 2025
src/client/chat/utils.ts
Outdated
| ); | ||
| } | ||
| throw new Error( | ||
| `This tool cannot be used for Jupyter Notebooks. Install the Jupyter Extension (${JUPYTER_EXTENSION_ID}) & try using notebook specific tools instead.`, |
There was a problem hiding this comment.
@rebornix From my testing this works as expected.
roblourens
approved these changes
May 21, 2025
anthonykim1
pushed a commit
to anthonykim1/vscode-python
that referenced
this pull request
Jun 5, 2025
…t#25098) @karthiknadig @eleanorjboyd @rebornix @amunger This change will change how the Python tools work. The python tools will no longer work with Notebooks. Previously it would, From my testing, this change works perfectly well. I think thats fraught with danger. There are a lot of things to consider. **Ideally there should ever be only one way of doing things, whether its local/remote/python/non-python notebooks.**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@karthiknadig @eleanorjboyd @rebornix @amunger
This change will change how the Python tools work.
The python tools will no longer work with Notebooks.
Previously it would,
From my testing, this change works perfectly well.
I think thats fraught with danger. There are a lot of things to consider.
Ideally there should ever be only one way of doing things, whether its local/remote/python/non-python notebooks.