Fixes #3530: codelens test run works without exception. #3577
Conversation
Updates `sys.exit(...)` to `os._exit(...)`, which is similar but does not raise an exception before exiting.
|
|
|
Thanks for the PR @cwharris. We will review this PR and have feedback for you by the end of our next sprint (end of December), at the very latest. |
|
@brettcannon |
|
The only problem is we don't have any functional tests for these. Apart from that all seems to be good. As for adding functional tests I believe that will be difficult, as the tests would require launching the debugger, etc. |
|
@cwharris Thanks for the PR, however we cannot accept this solution. |
|
@DonJayamanne This code is causing behavior we don't want. Would you rather use a catch-all and return? |
|
@cwharris if that results in proper behaviour then switching to |
Fixes #3530
Updates
sys.exit(...)toos._exit(...), which is similar but does not raise a SystemExit exception, thus allowing CodeLens to finish without the debugger breaking on exit.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)