Thanks to visit codestin.com
Credit goes to github.com

Skip to content

close restart session right away #7153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2019
Merged

close restart session right away #7153

merged 2 commits into from
Aug 30, 2019

Conversation

IanMatthewHuff
Copy link
Member

For #6975

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

IanMatthewHuff
IanMatthewHuff commented Aug 29, 2019
View reviewed changes
src/client/datascience/jupyter/jupyterSession.ts
@@ -124,8 +123,8 @@ export class JupyterSession implements IJupyterSession {
if (oldStatusHandler) {
oldSession.statusChanged.disconnect(oldStatusHandler);
}
// Don't shutdown old sessions yet. This seems to hang tests.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me worry a bit, but I tried the tests locally with both mock and real jupyter and they all passed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They might have issues on AzDO (I've seen that at times) but this code looks clearly wrong and we can always investigate a failing test later.

@codecov-io
Copy link

codecov-io commented Aug 30, 2019 •
edited
Loading

Codecov Report

Merging #7153 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7153      +/-   ##
==========================================
- Coverage    58.5%   58.43%   -0.07%     
==========================================
  Files         485      485              
  Lines       21446    21446              
  Branches     3462     3462              
==========================================
- Hits        12546    12533      -13     
- Misses       8122     8137      +15     
+ Partials      778      776       -2
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 76.47% <0%> (-11.77%) ⬇️
src/client/common/logger.ts 68.55% <0%> (-6.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9183405...277d904. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit 39cf9e0 into microsoft:master Aug 30, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/restartLeak branch August 30, 2019 16:54
IanMatthewHuff added a commit to IanMatthewHuff/vscode-python that referenced this pull request Aug 30, 2019
@IanMatthewHuff
close restart session right away (microsoft#7153)
28a6835 
* close restart session right away

* ignore errors on await, don't want to stop and wait for shutdown
@IanMatthewHuff IanMatthewHuff mentioned this pull request Aug 30, 2019
Merged
10 tasks
IanMatthewHuff added a commit that referenced this pull request Aug 30, 2019
@IanMatthewHuff
close restart session right away (#7153) (#7161)
a29ca3f 
* close restart session right away

* ignore errors on await, don't want to stop and wait for shutdown
kimadeline added a commit that referenced this pull request Sep 4, 2019
@kimadeline
Merge September release back into master (#7194)
911c7db 
* add cron job to nightly tests (#7128) (#7158)
* close restart session right away (#7153) (#7161)
* close restart session right away
* ignore errors on await, don't want to stop and wait for shutdown
* Release changes (#7183)
* Update package version
@lock lock bot locked as resolved and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DavidKutu DavidKutu DavidKutu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IanMatthewHuff @codecov-io @DavidKutu