Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add cron job to nightly tests (#7128) #7158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2019
Merged

add cron job to nightly tests (#7128) #7158

merged 1 commit into from
Aug 30, 2019

Conversation

IanMatthewHuff
Copy link
Member

Port of this PR to release:
#7128

The AzDO pipeline schedules added via the UI have been deprecated. I made a change in master to add in a cron job to do the nightly build. However since this yaml change is only in master branch it only applies to master branch so right now only master branch is getting built on schedule. Pulling in this change will get release on the schedule as well. I've just been building release manually for the last day or two to work around this.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff added the no-changelog No news entry required label Aug 30, 2019
kimadeline
kimadeline approved these changes Aug 30, 2019
View reviewed changes
Copy link

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍒 ⛏

@codecov-io
Copy link

codecov-io commented Aug 30, 2019 •
edited
Loading

Codecov Report

Merging #7158 into release will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           release    #7158      +/-   ##
===========================================
- Coverage    58.48%   58.43%   -0.06%     
===========================================
  Files          485      485              
  Lines        21437    21437              
  Branches      3462     3462              
===========================================
- Hits         12537    12526      -11     
- Misses        8122     8135      +13     
+ Partials       778      776       -2
Impacted Files Coverage Δ
src/client/common/logger.ts 68.55% <0%> (-6.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 732c987...3d42290. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit c45ab8d into microsoft:release Aug 30, 2019
kimadeline added a commit that referenced this pull request Sep 4, 2019
@kimadeline
Merge September release back into master (#7194)
911c7db 
* add cron job to nightly tests (#7128) (#7158)
* close restart session right away (#7153) (#7161)
* close restart session right away
* ignore errors on await, don't want to stop and wait for shutdown
* Release changes (#7183)
* Update package version
@lock lock bot locked as resolved and limited conversation to collaborators Sep 6, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/release-ports branch July 9, 2020 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kimadeline kimadeline kimadeline approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IanMatthewHuff @codecov-io @kimadeline