Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Preparation for point release #7268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Conversation

DavidKutu
Copy link

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #7268 into release will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           release    #7268      +/-   ##
===========================================
- Coverage    58.46%   58.43%   -0.04%     
===========================================
  Files          485      485              
  Lines        21437    21437              
  Branches      3462     3462              
===========================================
- Hits         12533    12526       -7     
- Misses        8123     8135      +12     
+ Partials       781      776       -5
Impacted Files Coverage Δ
src/client/common/logger.ts 68.55% <0%> (-4.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799344b...8cfed63. Read the comment docs.

@DavidKutu DavidKutu added the no-changelog No news entry required label Sep 6, 2019
@DavidKutu DavidKutu merged commit 40a28fa into release Sep 6, 2019
@DavidKutu DavidKutu deleted the davidkutu/scroll_fix_point_release branch September 6, 2019 23:18
DavidKutu pushed a commit that referenced this pull request Sep 9, 2019
* add cron job to nightly tests (#7128) (#7158)

* close restart session right away (#7153) (#7161)

* close restart session right away

* ignore errors on await, don't want to stop and wait for shutdown

* Release changes (#7183)

* check the position of the scroll in the interactive (#7198) (#7236)

* check the position of the scroll in the interactive
window, if it is at the bottom, the screen stays at the
bottom, and if not, the screen stays in place.
Throttling of the scroll was increased to help with
consistency on rapidly appearing plots.

* handle the scroll in the MainPanel, tested to work
with: - regular code, -dataframes, -big and regular plots.

* Added some comments.

* Turned the check of the scroll at the bottom from  … (#7259)

checking equal to checking a range to make it work with fractions.

* Preparation for point release (#7268)
@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants