Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

MikhailArkhipov
Copy link

@MikhailArkhipov MikhailArkhipov commented Sep 18, 2019

For #7475
The setting is still experimental so no news for now.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #7468 into master will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7468      +/-   ##
==========================================
+ Coverage   58.23%   58.56%   +0.32%     
==========================================
  Files         494      494              
  Lines       21785    21785              
  Branches     3484     3489       +5     
==========================================
+ Hits        12687    12758      +71     
+ Misses       8309     8238      -71     
  Partials      789      789
Impacted Files Coverage Δ
src/client/language/characters.ts 33.33% <0%> (+2.56%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (+5.55%) ⬆️
src/client/datascience/cellFactory.ts 89.65% <0%> (+13.79%) ⬆️
src/client/common/utils/icons.ts 100% <0%> (+16.66%) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (+25%) ⬆️
src/client/api.ts 87.5% <0%> (+25%) ⬆️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (+33.33%) ⬆️
src/client/testing/codeLenses/main.ts 77.77% <0%> (+33.33%) ⬆️
src/client/testing/serviceRegistry.ts 95.49% <0%> (+46.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e4a83...5ae8848. Read the comment docs.

@kimadeline kimadeline merged commit bb1b9de into microsoft:master Sep 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants