Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix monacoEditor perf and intellisense in the interactive window #7476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Sep 18, 2019

For #7241

Change monacoEditor to be attached to a dom node that isn't in the tree during creation.

Reattach this dom node later. This prevents the initial layout from taking too long.

@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #7476 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7476   +/-   ##
=======================================
  Coverage   58.53%   58.53%           
=======================================
  Files         494      494           
  Lines       21799    21799           
  Branches     3495     3495           
=======================================
  Hits        12761    12761           
  Misses       8247     8247           
  Partials      791      791
Impacted Files Coverage Δ
src/datascience-ui/interactive-common/mainState.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 631acd2...c0cbd10. Read the comment docs.

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit 9affc39 into master Sep 18, 2019
@rchiodo rchiodo deleted the rchiodo/monaco_layout branch September 18, 2019 22:26
@lock lock bot locked as resolved and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants