Support tracking dirty state of unclosed files #7532
Conversation
| @@ -39,16 +49,22 @@ export class NativeEditorProvider implements INotebookEditorProvider, IAsyncDisp | |||
| if (findFilesPromise && findFilesPromise.then) { | |||
| findFilesPromise.then(r => this.notebookCount += r.length); | |||
| } | |||
|
|
|||
| // // Reopen our list of files that were open during shutdown. Actually not doing this for now. The files | |||
There was a problem hiding this comment.
I'm a bit confused on this. Why are we adding the memento here then?
There was a problem hiding this comment.
We don't actually need it. I left it here in case we changed our minds.
There was a problem hiding this comment.
But it's not exactly complicated. I can just remove its usage
There was a problem hiding this comment.
Yeah, I just wanted adding it removed if we are not consuming it yet. Fine to keep it commented out, but I didn't want it in the storage and not being used.
In reply to: 327248488 [](ancestors = 327248488)
Codecov Report
@@ Coverage Diff @@
## master #7532 +/- ##
=======================================
Coverage 58.85% 58.85%
=======================================
Files 492 492
Lines 21823 21823
Branches 3501 3501
=======================================
Hits 12843 12843
Misses 8179 8179
Partials 801 801
Continue to review full report at Codecov.
|
For #7418
Use the workspace memento to track dirty state of files as the user makes them dirty