Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Install ptvsd wheels for all tests #7555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 24, 2019
Merged

Install ptvsd wheels for all tests #7555

merged 4 commits into from
Sep 24, 2019

Conversation

kimadeline
Copy link

@kimadeline kimadeline commented Sep 23, 2019 •
edited
Loading

CI borked when merging #7152

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Sep 23, 2019
ericsnowcurrently
ericsnowcurrently approved these changes Sep 23, 2019
View reviewed changes
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Sep 23, 2019 •
edited
Loading

Codecov Report

Merging #7555 into master will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7555      +/-   ##
==========================================
+ Coverage   58.56%   58.98%   +0.42%     
==========================================
  Files         492      492              
  Lines       21852    21916      +64     
  Branches     3499     3512      +13     
==========================================
+ Hits        12798    12928     +130     
+ Misses       8252     8185      -67     
- Partials      802      803       +1
Impacted Files Coverage Δ
src/client/common/utils/localize.ts 93.24% <0%> (-0.63%) ⬇️
src/client/datascience/types.ts 100% <0%> (ø) ⬆️
src/client/language/characters.ts 33.33% <0%> (+2.56%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (+5.55%) ⬆️
src/client/datascience/cellFactory.ts 89.65% <0%> (+13.79%) ⬆️
src/client/common/utils/icons.ts 100% <0%> (+16.66%) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (+25%) ⬆️
src/client/api.ts 87.5% <0%> (+25%) ⬆️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (+33.33%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d97fee9...124ba80. Read the comment docs.

@kimadeline kimadeline merged commit 558249b into microsoft:master Sep 24, 2019
@kimadeline kimadeline deleted the fix-ci-ptvsd-wheels branch September 24, 2019 00:05
@lock lock bot locked as resolved and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@karrtikr karrtikr Awaiting requested review from karrtikr

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimadeline @codecov-io @ericsnowcurrently