Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: remove misleading Node 10 TODO comments - #2592

Merged
ConnorQi01 merged 3 commits into
masterfrom
dev/v-peq/removeNode10TodoComments
May 8, 2026
Merged

ConnorQi01 merged 3 commits into
masterfrom
dev/v-peq/removeNode10TodoComments

Conversation

@ConnorQi01

@ConnorQi01 ConnorQi01 commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace TODO comment in appWorker.ts (WORKER_BOOTSTRAP string) with an explanation
    that the polyfill is required because the code runs in the user's RN environment where
    import/require are unavailable.
  • Replace TODO comment in forkedAppWorker.ts with an explanation that the simple
    file:// string concatenation is intentionally kept to avoid URL encoding side-effects
    from url.pathToFileURL().

Files changed

  • src/debugger/appWorker.ts
  • src/debugger/forkedAppWorker.ts

Plan de test

  • Run gulp build — no errors
  • Verify no functional behavior changed (comments only)

Closes #2607

@ConnorQi01

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ConnorQi01

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ConnorQi01

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ConnorQi01

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ConnorQi01
ConnorQi01 merged commit 0f8e919 into master May 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Remove misleading Node 10 TODO comments

2 participants