Added support for Build Multiple Versions of React Native app - #766
Merged
Merged
Conversation
| `${projectFile.projectName}.app`, "Info.plist"); | ||
| public getBundleId(projectRoot: string, simulator: boolean = true, configuration: string = "Debug", productName?: string): Q.Promise<string> { | ||
| const productsFolder = path.join(projectRoot, "build", "Build", "Products"); | ||
| const configutationFolder = path.join(productsFolder, `${configuration}${simulator ? "-iphonesimulator" : "-iphoneos"}`); |
Contributor
There was a problem hiding this comment.
Seems to be that there is a typo: configutationFolder.
Ruslan Bikkinin (ruslan-bikkinin)
approved these changes
Aug 8, 2018
Simon Reggiani (sregg)
suggested changes
Aug 8, 2018
| super(runOptions, platformDeps); | ||
|
|
||
| const configurationIdx = this.runArguments.indexOf("--configuration"); | ||
| const configuration = configurationIdx > -1 ? this.runArguments[configurationIdx + 1] : ""; |
There was a problem hiding this comment.
Are you sure configurationIdx + 1 is what you wanted here?. Seems like configurationIdx is the right index...
There was a problem hiding this comment.
I tried it and got this:
Could not debug. Could not found executable in /Users/simonreggiani/app/ios/build/Build/Products/-iphonesimulator
with this launch.json:
{
"name": "Debug iOS - iPhone X - Dev",
"program": "${workspaceRoot}/.vscode/launchReactNative.js",
"type": "reactnative",
"request": "launch",
"platform": "ios",
"sourceMaps": true,
"outDir": "${workspaceRoot}/.vscode/.react",
"runArguments": [
"--simulator=iPhone X",
"--scheme=app-dev",
"--configuration=Dev.Debug"
]
}
Contributor
Author
There was a problem hiding this comment.
Thanks for testing!
Actually we can fill runArguments like :
"runArguments": [
"--simulator", "iPhone X",
"--scheme", "app-dev",
"--configuration", "Dev.Debug"
]
I'll add support for both cases!
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
==========================================
- Coverage 14.39% 14.32% -0.07%
==========================================
Files 63 62 -1
Lines 3259 3273 +14
Branches 416 427 +11
==========================================
Hits 469 469
- Misses 2790 2804 +14
|
Ruslan Bikkinin (ruslan-bikkinin)
added a commit
to ruslan-bikkinin/vscode-react-native
that referenced
this pull request
Aug 28, 2018
…microsoft#766)" This reverts commit 3e313f6.
Ruslan Bikkinin (ruslan-bikkinin)
added a commit
that referenced
this pull request
Aug 28, 2018
* Revert "FIx incorrect runArguments assignment (#779)" This reverts commit b9fbf69. * Revert "Update changelog (#775)" This reverts commit 5517641. * Revert "Remove code push images (#771)" This reverts commit b34bce9. * Revert "Added support for Build Multiple Versions of React Native app (#766)" This reverts commit 3e313f6. * Revert "Update debugging.md (#765)" This reverts commit fcfec28. * Revert "fix typo (#763)" This reverts commit 4dd439f. * merge * Revert "Use fork instead of spawn for AppWorker (#760)" This reverts commit 2df05fa. * Revert "Added some logging for debug (#759)" This reverts commit 46e2461. * Revert "[Android] Add reading SDK location from local.properties (#754)" This reverts commit 43e1a99. * Revert "Fixed error while stop expo packager (#753)" This reverts commit 77b86bf.
|
Artem Egorov (@itoys) I can't figure out how I can specify the |
|
I see that it's reverted for some reason in 0.16.6 and added again in master (unreleased). That's probably why I can't get it to work.. Ruslan Bikkinin (@ruslan-bikkinin) any chance this can be released again? |
Contributor
|
Hi Ruben (@freakinruben), we are going to release new version at the beginning of the next week. I'll keep you posted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #764