Fix DevMenu call command for iOS - #992
Merged
Merged
Conversation
Yuri Skorokhodov (SounD120)
requested a review
from Ruslan Bikkinin (ruslan-bikkinin)
April 29, 2019 11:47
Co-Authored-By: SounD120 <[email protected]>
Yuri Skorokhodov (SounD120)
requested a review
from Ruslan Bikkinin (ruslan-bikkinin)
April 29, 2019 12:46
Ruslan Bikkinin (ruslan-bikkinin)
approved these changes
Apr 29, 2019
Ruslan Bikkinin (ruslan-bikkinin)
added a commit
that referenced
this pull request
May 23, 2019
* Update extension description (#895) * Update sourceMapsPathOverrides string with doc path, replace `sourcemap` by `source map` (#911) * Replace exponent with Expo (#912) * Add tool for getting changelog for version (#917) * Add script implementation and tests * Fix tests * Add real changelog testcase * Remove debug code * Fix lint * Remove get-changelog tool (#919) * Fix broken sentence (#886) * add missing doublequotes (#924) * Update vscode-nls-dev to the latest version for compatibility with MLCP (#930) Fix pt-BR language tag * Fix https://www.npmjs.com/advisories/755 (#932) * 2019-03-12. Merged in Translation. (#933) * 2019-03-12. Merged in Translation. * Update command pallete translations Fix test * Fix ios debugging on RN 0.59 (#937) * Add fix for rn 0.59 * Fix projectRoot, add license mentions * Add engaging scheme from args, add tests * Fix indent * Update src/extension/ios/plistBuddy.ts * Remove require * Update src/extension/ios/plistBuddy.ts * Prepare for 0.9.0 (#938) * Prepare for 0.9.0 * Update changelog * Fix "Run Android on Emulator" wording (#926) * Add debuggerWorkerUrlPath parameter for debugger configuration (#951) * Add tests * Fix js-yaml vulnerability (#952) Bump core deps * Update docs section for running pure React Native apps via Expo (#954) * Prepare for 0.9.1 (#959) * Update TPN (#961) * Update settings.json (#962) * Fix logging for attach function (#967) * Add information about potential problems with React Native sourcemaps (#975) * deps: [email protected], several transitive deps (#977) * Patch for console.trace() handler to avoid throwing error on native app (#976) * Patch for console.trace() handler, that redefines Node.js implementation * Add test for console.trace command * Update node typings to node@10 * Prepare for 0.9.2 (#979) * Add ability to save extension logs to files (#982) * [Docs] Adding a bug to known issues in the readme for adding configuration in VSCode (#986) * Adding a bug to known issues in the readme * Update README.md Co-Authored-By: springcoil <[email protected]> * Fix known issues table (#987) * Fix DevMenu call command for iOS (#992) * Add check for platform for iOS platform * Rewrite DevMenu call logic * Fix for node debugging process arguments due to end of life of --debug-brk arg in Node 12 (#1001) * Fix scheme parameter ambiguity (#995) * Fix scheme parameter ambiguity * Fix scheme parameter reading from runArguments * Prepare for 0.9.3 (#1003)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #978