Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Omitting resource type packages, and prompting for architecture in some cases #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
palenshus merged 1 commit into from
May 13, 2021
Merged

Omitting resource type packages, and prompting for architecture in some cases #14

palenshus merged 1 commit into from
May 13, 2021

Conversation

@palenshus
Copy link
Contributor

@palenshus palenshus commented May 13, 2021 •
edited
Loading

Fixes #12, Fixes #13

  • Adds filtering to ensure we don't generate installer nodes for resource msix packages
  • Adds logic to prompt for Architecture when we can't trust that we got it right
  • Adds --submit option to wingetcreate command in release pipeline
  • Standardizes the command name in the CommandExecutedEvents
Microsoft Reviewers: Open in CodeFlow

@palenshus palenshus requested review from a team and ryfu-msft May 13, 2021 22:00
@ghost ghost added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Issue-Bug labels May 13, 2021
ryfu-msft
ryfu-msft approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@ryfu-msft ryfu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@palenshus palenshus merged commit 2fcf879 into main May 13, 2021
@palenshus palenshus deleted the bugs branch May 13, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ryfu-msft ryfu-msft ryfu-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Issue-Bug Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parsing msixbundle generates installer node for resource packages "New" command should allow editing of architecture, since we may get it wrong

3 participants

@palenshus @ryfu-msft