Get new RelativeFilePaths if previous do not exist #415
Conversation
7a411e9 to
e229504
Compare
|
The GitHub diffs are not correct after 83973aa. I modified the UpdateSingleInstallerInteractively method but that method had both mixed line endings (CRLF and LF) because of which the diffs are messed up. If you check out the changes in Visual Studio, it'll show you the correct diffs.
If you like I can fix the line endings for UpdateCommand.cs and PackageParser.cs in a new commit as they are the two most high traffic files, though that'll mess the diffs up even more for this PR |
ryfu-msft
left a comment
There was a problem hiding this comment.
Just a couple nit comments
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
If you can do this in a separate PR (after this gets checked in) that would be a huge help! 🙏 |
Gotcha! Will do after this one. I was shying away from fixing the line endings since it'll mess up the |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This change makes it so we take the last portion of the RelativeFilePath i.e., the file name and search that file name in the new archive for a match. If it is a unique match, we get its RelativeFilePath and use it for the update.
Known limitation is that there are some cases where there may be more than one match in the archive (An example of this being DynamoRIO.DynamoRIO package). This is not handled in this PR and we print out an appropriate message to the user. I'll create an issue for it if this PR gets accepted.
The change to use the whole NestedInstallerFile object instead of previous RelativeFilePaths is so that I can replace this whole object in UpdateInstallerMetadata() and have it updated.
Test packages
Somes packages I found to test this PR with
Multiple matches for RelativeFilePaths (not handled in this PR)
Microsoft Reviewers: codeflow:open?pullrequest=#415