Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(a11y): correct person-card contact icons hover style accessibility contrast #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2024
Merged

fix(a11y): correct person-card contact icons hover style accessibility contrast #3174

merged 2 commits into from
May 14, 2024

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented May 13, 2024 •
edited
Loading

Closes #3132

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner May 13, 2024 10:11
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

1 similar comment
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@Mnickii Mnickii changed the title fix: correct person-card contact icons hover style accessibility contrast fix(a11y): correct person-card contact icons hover style accessibility contrast May 13, 2024
@Mnickii
Copy link
Collaborator Author

Mnickii commented May 13, 2024

@Raisul123 @vagpt please confirm that this fixes the issue

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 85% 67% 0 ✔
mgt-components.src.components.mgt-contact 63% 100% 0 ➖
mgt-components.src.components.mgt-file 62% 100% 0 ➖
mgt-components.src.components.mgt-file-list 46% 100% 0 ❌
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0 ❌
mgt-components.src.components.mgt-get 22% 100% 0 ❌
mgt-components.src.components.mgt-messages 68% 100% 0 ➖
mgt-components.src.components.mgt-organization 47% 100% 0 ❌
mgt-components.src.components.mgt-person 82% 100% 0 ✔
mgt-components.src.components.mgt-person-card 70% 56% 0 ➖
mgt-components.src.components.mgt-picker 80% 100% 0 ✔
mgt-components.src.components.mgt-profile 40% 100% 0 ❌
mgt-components.src.components.mgt-tasks-base 87% 100% 0 ✔
mgt-components.src.components.mgt-theme-toggle 100% 100% 0 ✔
mgt-components.src.components.mgt-todo 79% 100% 0 ✔
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0 ✔
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0 ✔
mgt-components.src.graph 38% 78% 0 ❌
mgt-components.src.styles 92% 80% 0 ✔
mgt-components.src.utils 78% 12% 0 ✔
mgt-element.dist.es6.components.src.components 72% 73% 0 ➖
mgt-element.dist.es6.mock.src.mock 90% 72% 0 ✔
mgt-element.dist.es6.providers.src.providers 85% 73% 0 ✔
mgt-element.dist.es6.src 91% 80% 0 ✔
mgt-element.dist.es6.utils.src.utils 68% 71% 0 ➖
mgt-element.src 93% 40% 0 ✔
mgt-element.src.components 78% 100% 0 ✔
mgt-element.src.mock 81% 56% 0 ✔
mgt-element.src.providers 84% 100% 0 ✔
mgt-element.src.utils 72% 91% 0 ➖
Summary 67% (14375 / 21559) 74% (490 / 666) 0 ➖

@Mnickii Mnickii merged commit 8078496 into main May 14, 2024
@Mnickii Mnickii deleted the fix/bug-3132 branch May 14, 2024 07:02
@gavinbarron gavinbarron mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@musale musale musale approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
2 participants
@Mnickii @musale