Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

YuuichiAkagawa
Copy link
Contributor

I found that the bit shifts for sender and recv in the ui hint of mtFFunctionBlockInfoNotify() are incorrect.

Repro

 //  ui hint is sender only = 0x2n
  uint8_t fbIdx = 0;
  bool active = true;
  uint8_t direction = 2;//bidirectional
  bool sender = true;   //sender only
  bool recv = false;    //
  uint8_t firstGroup = 0;
  uint8_t groupLength = 1;
  uint8_t midiCISupport = 0;
  uint8_t isMIDI1 = 0;
  uint8_t maxS8Streams = 1;

  std::array<uint32_t, 4> mess = UMPMessage::mtFFunctionBlockInfoNotify(fbIdx, active, direction, sender, recv, firstGroup, groupLength, midiCISupport, isMIDI1, maxS8Streams);
  tud_ump_write(BOARD_TUD_RHPORT, mess.data(), mess.size());

USB Packet (Before fix)

USB capture

USB Packet (After fix)

pr_fbin_fix_aftercap

@starfishmod starfishmod merged commit eef339f into midi2-dev:main Aug 4, 2025
@YuuichiAkagawa YuuichiAkagawa deleted the pr_fbin_fix branch August 5, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants