Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH: remove warning suppression #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hongyeehh merged 3 commits into from
Jun 29, 2023
Merged

ENH: remove warning suppression #481

hongyeehh merged 3 commits into from
Jun 29, 2023

Conversation

@bifbof
Copy link
Collaborator

@bifbof bifbof commented Jun 28, 2023 •
edited
Loading

As of geopandas 0.12.0, these warnings have been fixed and should no longer be suppressed.
Further should close #463 as the discussed problem does not occur anymore, can be tested with this code:

import geopandas as gpd
import pandas as pd
from shapely.geometry import Point

gdf = gpd.GeoDataFrame([{"a":1, "g": Point(1, 2)}], geometry="g", crs=4326)
gdf_empty = gpd.GeoDataFrame()
gdf_concat = pd.concat([gdf, gdf_empty])
assert gdf.crs == gdf_concat.crs

@bifbof bifbof marked this pull request as ready for review June 28, 2023 15:20
@bifbof bifbof requested a review from hongyeehh June 28, 2023 15:20
@hongyeehh hongyeehh self-assigned this Jun 28, 2023
hongyeehh
hongyeehh reviewed Jun 29, 2023
View reviewed changes
@hongyeehh
Copy link
Member

hongyeehh commented Jun 29, 2023

Thanks for taking care of the warnings. The warning fixes are fine, I would just keep the issue #463 open (and the corresponding comments in the code) as it is not entirely solved

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (c9b3b06) 92.35% compared to head (3b005a3) 92.31%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
- Coverage   92.35%   92.31%   -0.04%     
==========================================
  Files          39       39              
  Lines        2014     2004      -10     
  Branches      344      340       -4     
==========================================
- Hits         1860     1850      -10     
  Misses        133      133              
  Partials       21       21
Impacted Files Coverage Δ
trackintel/model/util.py 100.00% <100.00%> (ø)
trackintel/preprocessing/staypoints.py 99.01% <100.00%> (-0.02%) ⬇️
trackintel/preprocessing/triplegs.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hongyeehh hongyeehh merged commit 1b29cdd into mie-lab:master Jun 29, 2023
@bifbof bifbof deleted the remove_warning_surpression branch June 29, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongyeehh hongyeehh hongyeehh approved these changes

Assignees

@hongyeehh hongyeehh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change default behaviour of merge_staypoint()

2 participants

@bifbof @hongyeehh