Tags: migtools/oadp-cli
Tags
Merge pull request #161 from oadp-rebasebot/rebase-bot-oadp-1.6 Merge https://github.com/migtools/oadp-cli:oadp-1.6 (646f232) into oadp-1.6
General fixes (#112) * Fix gzip decompression for backup downloads and enhance describe command This commit addresses issues with compressed backup data and adds new functionality for detailed backup information: Download improvements: - Fix gzip detection to check file magic bytes (0x1f 0x8b) in addition to Content-Encoding header. Object storage signed URLs often serve .gz files without the Content-Encoding header, causing decompressed content to be displayed as binary gibberish - Add comprehensive debug logging to download functions for easier troubleshooting - Use buffered reader with Peek() to detect gzip format without consuming the stream Describe command enhancements: - Add --details flag to fetch additional backup information including volume snapshots, resource lists, backup results, and item operations - Exclude describe command from output wrapper (similar to logs command) to prevent buffering issues with large downloads - Update tests to reflect describe command exclusion Installation improvements: - Enhance make install output formatting with clearer status messages - Show version info during installation verification Co-Authored-By: Claude Sonnet 4.5 <[email protected]> Signed-off-by: Joseph <[email protected]> * Refactor download request logic to eliminate code duplication Extract common download request creation and polling logic into a new shared function CreateAndWaitForDownloadURL. This eliminates ~53 lines of duplicated code between the logs and describe commands. Key changes: - Add CreateAndWaitForDownloadURL function to handle request creation and polling with optional progress callbacks - Add OnProgress callback to DownloadRequestOptions for progress indication - Refactor logs command to use shared function (75 lines → 22 lines) - Simplify printDetailedBackupInfo to accept backup name string instead of full NonAdminBackup object - Remove debug log statements from download.go - Clean up unused imports in logs.go This maintains the key behavioral difference between commands: - logs: streams content for low memory usage - describe --details: buffers content for formatting Co-Authored-By: Claude Sonnet 4.5 <[email protected]> Signed-off-by: Joseph <[email protected]> * Improve nonadmin backup describe output formatting Align nonadmin backup describe output with admin backup format: - Move Resource List before Backup Volumes section to match admin order - Parse and format Resource List JSON as hierarchical structure with bullets - Skip printing sections with no data (empty snapshots, no errors/warnings) - Parse and format Volume Snapshot Details, Backup Results, and Item Operations as readable JSON - Split Backup Results into separate Errors and Warnings subsections Co-Authored-By: Claude Sonnet 4.5 <[email protected]> Signed-off-by: Joseph <[email protected]> * Fix ineffectual assignment in backup describe command Remove unused assignment to hasOutput variable in printDetailedBackupInfo function. The assignment at line 447 had no effect since it was in the last section and the variable was never used afterward. Co-Authored-By: Claude Sonnet 4.5 <[email protected]> Signed-off-by: Joseph <[email protected]> --------- Signed-off-by: Joseph <[email protected]> Co-authored-by: Claude Sonnet 4.5 <[email protected]>
Flesh out autocomplete (#90) * Flesh out autocomplete Signed-off-by: Joseph <[email protected]> * binary name fix and use release-archives Signed-off-by: Joseph <[email protected]> * Remove bloat Signed-off-by: Joseph <[email protected]> --------- Signed-off-by: Joseph <[email protected]>
Add new badges for release and multi-arch binary (#88) * Add new badges for release and multi-arch binary Signed-off-by: Joseph <[email protected]> * Pass build args for Containerfile in buildah Signed-off-by: Joseph <[email protected]> --------- Signed-off-by: Joseph <[email protected]>
Add .exe for windows executables (#84) Signed-off-by: Joseph <[email protected]>
Fix .krew and release archives (#83) Signed-off-by: Joseph <[email protected]>
CI fixes (#82) Signed-off-by: Joseph <[email protected]>
Change binary format to match krew bot (#78) * Change binary format to match krew bot Signed-off-by: Joseph <[email protected]> * Fix dependency on binary format Signed-off-by: Joseph <[email protected]> * Fix format Signed-off-by: Joseph <[email protected]> * New format instructions Signed-off-by: Joseph <[email protected]> --------- Signed-off-by: Joseph <[email protected]>
PreviousNext