Some Minor TODO fixes #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNU ld won't link foo-wm as-is, since the libraries are in the front. I separated compiler options (like -g and -Wall) from libraries (-lX11 and -lm) to prevent ld from failing.
This fix is mostly for pedagogical purposes, and not really intended to be used. Feel free to delete this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some minor changes to remove some of the low-hanging fruit from the TODO; specifically, there are now checks around
XMapWindowandXRaiseWindowinplaceNode:tree.c.I also fixed what seemed to be a problem with the Makefile - at least on my Ubuntu machine, GCC would fail to process the Makefile due to a bad linker order. The reordering change I made makes it compilable for me.