This repository was archived by the owner on Nov 28, 2019. It is now read-only.
Allow update callback to have $this #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The *update* callback should have a $this context, or argument passed so it is easier to use it to traverse, and find another element to which _current_percentage_ can be displayed. This could be used when multiple progressbars are used on the same page, each placed in it's logical group. The change is very trivial, plus to avoid breaking any existing users, I chose to add $this as a 2nd argument, although personally I'd prefer to pass $this as the first argument.
Owner
|
hi @visitsb, agree - it's a nice to have. but i have to mention that there's always a workaround. e.g instead of: $(document).ready(function() {
$('.progress .bar').progressbar({
update: function(percent, $this) {
$this.parent().css('background-color', 'rgb(' + Math.round(current_percentage / 100 * 255) + ', 0, 0)');
}
});
});you could do something like this: $(document).ready(function() {
$('.progress .bar').each(function () {
var $pb = $(this);
$pb.progressbar({
update: function(percent) {
$pb.parent().css('background-color', 'rgb(' + Math.round(current_percentage / 100 * 255) + ', 0, 0)');
}
});
});
});nonetheless it won't brick anything and it's definitely improving the usability so will will integrate it in the next release. thanks! |
minddust
added a commit
that referenced
this pull request
Aug 2, 2014
Allow update callback to have $this
Owner
|
forgot to merge =) |
Owner
|
btw. |
minddust
added a commit
that referenced
this pull request
Aug 2, 2014
Contributor
Author
|
@minddust Thanks! |
Owner
|
there's also a new demo using $this: http://www.minddust.com/project/bootstrap-progressbar/demo/bootstrap-3-1-1/#m-callback-this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update callback should have a
$thiscontext, or argument passed so it is easier to use it to traverse, and find another element to which current_percentage can be displayed. This could be used when multiple progressbars are used on the same page, each placed in it's logical group.The change is very trivial, plus to avoid breaking any existing users, I chose to add
$thisas a2ndargument, although personally I'd prefer to pass$thisas thefirstargument.An example below,
