Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Markdown properties docs#1

Closed
shroffk wants to merge 12 commits into
minijackson:markdown-properties-docsfrom
ControlSystemStudio:markdown-properties-docs
Closed

Markdown properties docs#1
shroffk wants to merge 12 commits into
minijackson:markdown-properties-docsfrom
ControlSystemStudio:markdown-properties-docs

Conversation

@shroffk

@shroffk shroffk commented Nov 4, 2025

Copy link
Copy Markdown

Trying to address build concerns

Checklist

  • Testing:

    • Tests were run
    • If not, explain how you tested your changes
  • Documentation:

    • The feature is documented
    • The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@shroffk

shroffk commented Nov 4, 2025

Copy link
Copy Markdown
Author

@minijackson please have a look and merge this
I will have Georg test this and we can hopefully have a more simpler/reliable build system moving forward

@minijackson minijackson left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Here are my comments:

Comment thread docs/pyproject.toml
Comment thread docs/README.md Outdated
Comment thread docs/README.md Outdated
@shroffk shroffk requested a review from minijackson November 5, 2025 15:13
Comment thread docs/pyproject.toml
channels = ["conda-forge"]
platforms = ["win-64", "linux-64", "osx-64", "osx-arm64"]

[tool.pixi.dependencies]

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[tool.pixi.dependencies]
[dependencies]

Else it won't work with other tools (such as pip or RtD)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is possible

PS C:\git\cs-studio\phoebus\docs> pixi run clean
Error:   x Missing table in manifest pyproject.toml:
  | Any of the following sections is required:
  | * tool.pixi.workspace
  | * tool.pixi.project
  | * tool.pixi.package
   ,-[C:\git\cs-studio\phoebus\docs\pyproject.toml:1:1]
 1 | [project]
   : ^
 2 | name = "phoebus-docs"
   `----
  help: Check your manifest for a [tool.pixi.*] table. See https://pixi.sh/latest/python/pyproject_toml for more information.

Comment thread docs/pyproject.toml
Comment thread docs/pyproject.toml Outdated
Comment thread docs/README.md Outdated
@shroffk

shroffk commented Nov 5, 2025

Copy link
Copy Markdown
Author

@minijackson
removed the requirements.txt

made the pyproject.toml the single source of dependency truth

@shroffk shroffk requested a review from minijackson November 5, 2025 16:29
@shroffk

shroffk commented Nov 6, 2025

Copy link
Copy Markdown
Author

@minijackson can we merge this

@shroffk shroffk closed this Nov 6, 2025
@shroffk shroffk deleted the markdown-properties-docs branch January 9, 2026 16:26
minijackson pushed a commit that referenced this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants