Fix condition on nullable property #1330
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ResponseResult.Exception is nullable by usages. We have to check that nullability for standard Error cas. eg when the SecretKey is invalid, an error is handled by this method and no exception is present in the ResponseResult object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResponseResult.Exceptionis nullable by usages. We have to check that nullability for standard Error cas.eg when the Minio client SecretKey is invalid, the error is handled by this method and no exception is present in the ResponseResult object.
This fix the null point exception that is thrown at this line and allow to properly retrieve the error message.